Repository navigation
Restore missing guide entries for Volume Box and Filler - #66
Merged
shipovskijkorp merged 1 commit intoOct 11, 2026
Merged
Conversation
… Planner pages The English text for buildcraftcore/item/box_volume (5 of 7 slots) and buildcraftbuilders/item/filler_planner (4 of 5 slots) no longer matched page_layouts.json, which failed OriginalGuideResourcesTester on the old build. Add the missing lore, hint and chapter title entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guide tests failed on 1.19.2 and 1.20.1 for
buildcraftcore/item/box_volume.page_layouts.jsondefines 7 text slots (lore, no_lore, hint, 2 chapters).text/en_us.jsonhad only 5 strings after ae3cd06, so the no_lore and hint entries were missing and later strings sat in the wrong slots.Fixes
sharedLayoutsAndEnglishHaveMatchingSlotsandeveryListedPageHasOptionalHints../build-all.shfailed to build because of this.