Repository navigation
Fix Facade Plugs Turning Invisible From Some Angles - #64
Merged
shipovskijkorp merged 8 commits intoOct 9, 2026
Merged
Conversation
…e-on-unix Make gradlew and build script executable on unix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Facade plug textures disappear when you looked at them from certain directions. One side was also upside down (see first image). Plugs get baked once and then rotated onto each side of the pipe. The rotation moved the vertices but left the face label alone, so Minecraft culled and shaded the rotated quads as if they still faced the old side.
What changed:
MutableQuad.rotatenow rotates the face label together with the geometry. It uses a small lookup table, so there's no extra allocation.DirectionCompat.nearestto cover the Direction API difference between versions.MutableQuadRotateTester. It fails without the fix.Tested:
rotateis shared by every pluggable, so gates, robot stations and the rest should get the fix too.Bugged:
Fixed: