Skip to content

Fix Linux CI typecheck failure in agent-panel.test.tsx - #3

Draft
AzureLandin with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-failing-github-actions-job
Draft

AzureLandin with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Aug 16, 2026

Copy link
Copy Markdown

Build (linux) was failing during npm run typecheck with TS2322 in tests/ui/agent-panel.test.tsx. The test helper used a mock-specific function type for onHide that was wider than the AgentPanel prop contract.

  • Root cause

    • renderPanel typed onHide as ReturnType<typeof vi.fn>, which is not assignable to (() => void) | undefined expected by AgentPanel.
  • Change

    • Narrowed onHide typing in the test helper (both override input and helper return type) to match the component prop:
      • onHide?: () => void
  • Why this resolves CI

    • Aligns the test helper signature with AgentPanelProps, removing the type incompatibility that breaks typecheck:test on Linux CI.
// before
onHide?: ReturnType<typeof vi.fn>

// after
onHide?: () => void

Co-authored-by: AzureLandin <238871501+AzureLandin@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Build (linux) Fix Linux CI typecheck failure in agent-panel.test.tsx Aug 16, 2026
Copilot AI requested a review from AzureLandin August 16, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants