Skip to content

ErrorException when saving post with no tags #61

Description

@pavsid

Creating a new post without any tags throws the following error:-

production.ERROR: ErrorException: array_diff(): Argument #1 is not an array in /home/asgardcms/public_html/Modules/Tag/Traits/TaggableTrait.php:104

Activity

  1. pavsid commented on Nov 16, 2017

    @pavsid
    Author

    This is the fix..

    EloquentPostRepository.php:47

    $post->setTags(array_get($data, 'tags', []));

  2. nWidart commented on Nov 16, 2017

    @nWidart
    Member

    Thanks, you can send a PR with this if you want.

  3. changed the title [-]ErrorException when saving creating new page with no tags[/-] [+]ErrorException when saving new page with no tags[/+] on Nov 16, 2017
  4. changed the title [-]ErrorException when saving new page with no tags[/-] [+]ErrorException when saving post with no tags[/+] on Nov 16, 2017
  5. pavsid commented on Nov 16, 2017

    @pavsid
    Author

    @nWidart I'd like to start contributing, and am following the steps listed here , but am stuck at Run ./travis.sh - never used travis before, and have never sent a PR before, can you give me some pointers please?!

  6. pavsid commented on Nov 16, 2017

    @pavsid
    Author

    No need for my PR anyway - looks like this issue was addressed in branch 2.0 so just needs merging into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions