pmp v1 implementation - #576
Open
dd-dreams wants to merge 4 commits into
Open
Conversation
dd-dreams
force-pushed
the
pmp-v1-impl
branch
6 times, most recently
from
August 24, 2026 08:29
9653038 to
ae66f0a
Compare
dd-dreams
force-pushed
the
pmp-v1-impl
branch
2 times, most recently
from
August 25, 2026 16:16
4582060 to
61a4ba0
Compare
WhatAmISupposedToPutHere
requested changes
Aug 25, 2026
WhatAmISupposedToPutHere
requested changes
Aug 25, 2026
dd-dreams
force-pushed
the
pmp-v1-impl
branch
3 times, most recently
from
August 26, 2026 18:50
50fd00e to
0408eee
Compare
WhatAmISupposedToPutHere
requested changes
Aug 26, 2026
dd-dreams
force-pushed
the
pmp-v1-impl
branch
2 times, most recently
from
August 26, 2026 19:21
28300e1 to
9b60733
Compare
WhatAmISupposedToPutHere
approved these changes
Aug 26, 2026
jannau
requested changes
Aug 29, 2026
jannau
left a comment
Member
There was a problem hiding this comment.
please clean your commits up. At least each commit should compile and each drivers should get their own commit. The dts changes need to be separate as well to avoid conflicts between bits/* branches
jpeisach
reviewed
Aug 31, 2026
| self, | ||
| ASC_CPU_CONTROL, // | ||
| }, | ||
| pmp_v1_bridge |
There was a problem hiding this comment.
Importing this fails when CONFIG_APPLE_PMP_V1 is set to m and not y
Author
There was a problem hiding this comment.
Why do you need it to be set to m? Not sure if we should mind m.
Signed-off-by: dd-dreams <80887265+dd-dreams@users.noreply.github.com>
Signed-off-by: dd-dreams <80887265+dd-dreams@users.noreply.github.com>
Signed-off-by: dd-dreams <80887265+dd-dreams@users.noreply.github.com>
Signed-off-by: dd-dreams <80887265+dd-dreams@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.