Repository navigation
Conversation
…swer on its pull request When data/ points to github.com/ORG/REPO, only the account ORG itself was treated as the upstream account, so a developer of the organization (#9760, RompEmu) could not use /retest, the automatic re-test on 'it is fixed' comments, the opt-out request or the not-upstream explanation. The new code/is-upstream-account.sh accepts the account itself and, for an organization, its public members (orgs/ORG/public_members/USER: 204); the four workflows use it. Private members are invisible to the API. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raised in #9760 (comment) (RompEmu):
data/RomPpoints togithub.com/RompEmu/RomP, and the account the AppImage comes from is the organizationRompEmu. Only that account itself counted as upstream, so a developer of the organization could not use/reteston the pull request that adds their own application.New
code/is-upstream-account.sh USER OWNER: exits 0 if USER is OWNER (case-insensitive), or OWNER is an organization and USER is a public member of it (GET /orgs/OWNER/public_members/USER, 204 means member); anything else, including an API error, exits 1. Only valid login names are looked at. Tested with a stub for the member, the organization itself in another capitalization, a stranger, and an invalid name.Used in the four places that compare the commenter with the upstream account:
retest.yml(/retest),auto-retest.yml(a comment that says it is fixed),opt-out-request.ymlandnot-upstream-explained.yml. The refusal message of/retestnow says that organization members who show their membership are included. AGENTS.md describes it.Limits, stated in the script and in AGENTS.md: a member who hides their membership is invisible to the API (private membership is only visible to other members of the organization), and has to make it public or ask a maintainer.
/removestays maintainers-only, as it deletes entries; there is no/closecommand in the workflows.bash -n, shellcheck and actionlint (apart from the pre-existing style findings inretest.yml) pass; the API call itself cannot be exercised from this sandbox.Generated by Claude Code