Skip to content

Window fitting and screenshot: accept negative window coordinates, ignore IceWM's own windows #10302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
probonopd merged 1 commit into from
Oct 16, 2026
Merged

Window fitting and screenshot: accept negative window coordinates, ignore IceWM's own windows #10302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/take-screenshot.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ if [ -n "$WINDOW" ] ; then
H=$(sed -n 's/.*Height: *\([0-9]*\).*/\1/p' <<<"$INFO")
else
# The largest application window, e.g.: 0x200006 "Game": ("game" "Game") 800x600+0+0 +0+0
read -r W H X Y < <(timeout 20 xwininfo -tree -root 2>/dev/null | grep '": ("' \
| sed -nE 's/.* ([0-9]+)x([0-9]+)[-+][-0-9]+[-+][-0-9]+ +([-+][0-9]+)([-+][0-9]+)$/\1 \2 \3 \4/p' \
read -r W H X Y < <(timeout 20 xwininfo -tree -root 2>/dev/null | grep '": ("' | grep -vi '"icewm"' \
| sed -nE 's/.* ([0-9]+)x([0-9]+)[-+]-?[0-9]+[-+]-?[0-9]+ +([-+]-?[0-9]+)([-+]-?[0-9]+)$/\1 \2 \3 \4/p' \
| awk '{ print $1 * $2, $0 }' | sort -rn | head -n 1 | cut -d " " -f 2-)
X=${X#+} ; Y=${Y#+}
fi
Expand Down
9 changes: 6 additions & 3 deletions code/worker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,9 +505,12 @@ fit_main_window() {
local SW SH LINE WID WW WH NW NH
read -r SW SH < <(timeout 5 xdotool getdisplaygeometry 2>/dev/null)
[[ "$SW" =~ ^[0-9]+$ && "$SH" =~ ^[0-9]+$ ]] || return 0
# The largest managed window (as take-screenshot.sh picks the app window)
LINE=$(timeout 20 xwininfo -tree -root 2>/dev/null | grep '": ("' \
| sed -nE 's/^[[:space:]]*(0x[0-9a-f]+) .* ([0-9]+)x([0-9]+)[-+][-0-9]+[-+][-0-9]+ +[-+][0-9]+[-+][0-9]+$/\1 \2 \3/p' \
# The largest managed window (as take-screenshot.sh picks the app window),
# not the window manager's own (IceWM's taskbar). A window placed partly off
# screen has negative absolute coordinates, which X11 writes as "+-320+-150"
# (#10156: a 1440x900 window centered on the 800x600 screen).
LINE=$(timeout 20 xwininfo -tree -root 2>/dev/null | grep '": ("' | grep -vi '"icewm"' \
| sed -nE 's/^[[:space:]]*(0x[0-9a-f]+) .* ([0-9]+)x([0-9]+)[-+]-?[0-9]+[-+]-?[0-9]+ +[-+]-?[0-9]+[-+]-?[0-9]+$/\1 \2 \3/p' \
| awk '{ print $2 * $3, $0 }' | sort -rn | head -n 1 | cut -d ' ' -f 2-)
read -r WID WW WH <<<"$LINE"
[[ -n "$WID" && "$WW" =~ ^[0-9]+$ && "$WH" =~ ^[0-9]+$ ]] || return 0
Expand Down