Skip to content

Fix OTA manifest lambda for ESPHome dev - #129

Closed
bharvey88 wants to merge 1 commit into
mainfrom
ota-url-const-char
Closed

bharvey88 wants to merge 1 commit into
mainfrom
ota-url-const-char

Conversation

@bharvey88

@bharvey88 bharvey88 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Version: 26.9.29.1

What does this implement/fix?

Fixes the build against ESPHome dev. esphome#19211 changed the http_request update entity's set_source_url() to take a const char * and keep the pointer, so passing a std::string fails with cannot convert 'std::string' to 'const char*'.

apply_ota_source now picks between the two manifest URLs as string literals, which stay valid for the life of the firmware. Current stable still accepts this, since its const std::string & parameter converts from const char *. No change in behavior.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Updated the default firmware version from 26.7.23.1 to 26.9.29.1. This release note reflects the firmware version change in the ESPHome integration; the selected Stable or Beta update source remains unchanged. No other end-user-facing changes are included in this update.

@bharvey88 bharvey88 added the bugfix Bug fix label Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 02955224-85e5-4434-8de2-0bf9e761fd37

📥 Commits

Reviewing files that changed from the base of the PR and between 33e456b and 710c7c4.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

The default ESPHome firmware version changes to 26.9.29.1. apply_ota_source stores and logs the selected Stable or Beta manifest URL as a const char *. The selected URL remains the update request source.

Changes

ESPHome firmware and OTA updates

Layer / File(s) Summary
Firmware default and OTA logging
Integrations/ESPHome/Core.yaml
The default firmware version changes to 26.9.29.1. apply_ota_source logs the selected manifest URL directly from a const char * and continues to set it as the update request source.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 710c7

No actionable merge-blocking issue is established by the reviewed changes; normal build validation remains appropriate.

Architecture Summary

Architecture risk: 🔵 Low · up to 33e45

The change affects 1 system.

Changed systems: Integrations

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — Integrations (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in Integrations/ESPHome/Core.yaml: The default firmware version changes from 26.8.27.1 to 26.9.29.1.
  • observed — Modified behavior in Integrations/ESPHome/Core.yaml: apply_ota_source now stores the selected manifest URL as a const char * and passes it directly to the log call instead of constructing a std::string and logging its c_str(). The Stable/Beta selection remains unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing OTA manifest selection in the ESPHome development build. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the firmware line,
A newer version takes its place.
Stable or Beta, URLs stay,
Logged directly in the flow.
The OTA source is still set,
And carrots wait beside the code.

Comment @coderabbitai help to get the list of available commands.

@bharvey88
bharvey88 changed the base branch from beta to main September 29, 2026 22:04
@bharvey88 bharvey88 closed this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants