Fix server-side transports on Python 3.11/3.12, and report accept-path errors loudly - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server._attach/_detachgained their transport argument in 3.13 (gh-113538); calling the 3.13 signature made every server-side connection on 3.11/3.12 fail with a TypeError at transport creation, silently, because the stdlib accept path reports such errors only in debug mode. The calls are now version-gated._make_socket_transportadditionally reports any server-side transport-creation failure through the loop's exception handler before re-raising, so this class of bug can no longer be invisible. The test helper switches fromasyncio.run(loop_factory=)(3.12+) toasyncio.Runner, fixing the suite itself on 3.11. Verified 11/11 on 3.11 through 3.14 locally, plus the full oracle sweep.