Repository navigation
Reject unsupported script-folder types - #385
Merged
Eli Pinkerton (wallstop) merged 2 commits intoOct 21, 2026
Merged
Conversation
Script-folder scans accept MonoBehaviours and plain classes that the ScriptableObject browser cannot manage. Require ScriptableObject assignability in shared eligibility and use one folder-discovery path. Keep deduplication, saved managed types and ordinal type ordering. Asset-folder discovery reads main-asset metadata without loading assets. The original predicate returned true for a plain test class on the live host. The final tree passes 705 EditMode and 15 PlayMode tests on Unity 6000.5.2f1 Windows, including actual script and asset scans, ordinary SOs and exclusions. The 16-step local gate passes. The npm archive matches checkout bytes and contains only the 249 allowed payload files. Unity 2021.3 and other platforms remain unexecuted. An initial full run hit a persistent native UI Toolkit lock assertion in 26 UI tests. A clean host restart removed the assertion; the full suite then passed without suppressing logs. No persistent host asset was dirty before restart. The clean host retains its original seven editor windows. Fixes #376.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 44d05f6. Configure here.
Folder pickers can return unimported or case-varied paths. Resolve scan folders through Unity GUIDs and return no matches for unavailable folders instead of throwing in the browser callback. Preserve strict eligibility. All 39 focused catalog cases pass on Unity 6000.5.2f1 Windows, including unimported folders, null/empty paths and case-varied real asset scans. The functional parent passed 705 EditMode and 15 PlayMode tests. The 16-step review gate passes. Unity 2021.3 and other platforms are unexecuted. Refs #376, #385. Address PRRT_kwDOOhJZ9s6upRue.
Eli Pinkerton (wallstop)
added this pull request to stack #387
October 21, 2026 06:34
This was referenced Oct 21, 2026
Eli Pinkerton (wallstop)
deleted the
fix/script-folder-type-eligibility
branch
October 21, 2026 18:44
12 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLOSURE: LLM-GENERATED TEXT
Why: Script-folder scans admit types the ScriptableObject browser cannot manage.
What:
Fixes #376
Type of Change
Checklist
Note
Overview
Fixes script-folder “add types” scans admitting types the ScriptableObject browser cannot manage (e.g.
MonoBehaviourscripts).EditorTypeCatalog.IsLoadableTypeis now public and requiresScriptableObjectassignability, so non–ScriptableObject script classes are rejected consistently with the rest of the eligibility rules.Folder discovery moves into
EditorTypeCatalog.FindTypesInFolder:DataVisualizer.AddTypesFromFoldercalls it and filters out already-managed types. Asset-folder scans useGetMainAssetTypeAtPathinstead of loadingScriptableObjectinstances, avoiding side effects during discovery.Tests cover eligibility matrix, real script/asset folder scans (including excluding behaviours), invalid/missing folders, and docs/CHANGELOG updates for the new API.
Reviewed by Cursor Bugbot for commit fa2166d. Bugbot is set up for automated code reviews on this repo. Configure here.