[Backport] fix(form-data): prevent input delays after navigating large forms - #4349
Merged
Merged
Conversation
) * fix(form-data): bound selector caches by data model path Repeated render paths create new binding objects for the same data type and field. The identity-based default key retained every object and made each later edit reevaluate all prior bindings. Pass a stable path key through the Zustand context helpers and use it for form-data delayed selectors. In RA-0846-01, a 44-character input stayed below 0.4 seconds after three full form tours, while the prior build rose to 6.9 seconds. * test(form-data): cover equivalent binding selector keys Exercise direct and lax delayed selectors with fresh objects for the same binding. Repeated renders must reuse the cached selection, while a store change must still update the displayed value. --------- Co-authored-by: Ole Martin Handeland <git@olemartin.org>
olemartinorg
approved these changes
Sep 30, 2026
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4348
This is an automated backport of PR #4348 to the
release/v4.33release branch.Original PR
Changes
Cherry-picked the merge commit from the original PR onto the release branch.
🤖 This backport PR was created automatically by the Auto Backport workflow.