Skip to content

[Backport] fix(form-data): prevent input delays after navigating large forms - #4349

Merged
olemartinorg merged 1 commit into
release/v4.33from
backport/4348
Sep 30, 2026
Merged

olemartinorg merged 1 commit into
release/v4.33from
backport/4348

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Backport of #4348

This is an automated backport of PR #4348 to the release/v4.33 release branch.

Original PR

Changes

Cherry-picked the merge commit from the original PR onto the release branch.


🤖 This backport PR was created automatically by the Auto Backport workflow.

)

* fix(form-data): bound selector caches by data model path

Repeated render paths create new binding objects for the same data type and field. The identity-based default key retained every object and made each later edit reevaluate all prior bindings.

Pass a stable path key through the Zustand context helpers and use it for form-data delayed selectors. In RA-0846-01, a 44-character input stayed below 0.4 seconds after three full form tours, while the prior build rose to 6.9 seconds.

* test(form-data): cover equivalent binding selector keys

Exercise direct and lax delayed selectors with fresh objects for the same binding. Repeated renders must reuse the cached selection, while a store change must still update the displayed value.

---------

Co-authored-by: Ole Martin Handeland <git@olemartin.org>
@github-actions github-actions Bot added automated backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/other Pull requests containing chores/repo structure/other changes labels Sep 30, 2026
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5cefc04e-25d5-4d85-b6c4-66d1a1143fcd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@olemartinorg
olemartinorg merged commit bf2a80a into release/v4.33 Sep 30, 2026
1 check passed
@olemartinorg
olemartinorg deleted the backport/4348 branch September 30, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/other Pull requests containing chores/repo structure/other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant