Skip to content

[PWGUD] Remove ZDC fields from MC output #17653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amatyja merged 2 commits into from
Aug 28, 2026
Merged

[PWGUD] Remove ZDC fields from MC output #17653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f56fab
Remove ZDC fields from MC
amatyja Aug 28, 2026
800b7d2
O2 linter and efficiency histo corrections
amatyja Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions PWGUD/DataModel/TauThreeProngEventTables.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,9 @@ DECLARE_SOA_TABLE(TrueTauFourTracks, "AOD", "TRUETAU",
// tautree::Trs, tautree::Trofs, tautree::Hmpr,
// tautree::Tfb, tautree::ItsRofb, tautree::Sbp, tautree::ZvtxFT0vsPv, tautree::VtxITSTPC,
//
tautree::ZdcAenergy, tautree::ZdcCenergy,
tautree::ZdcAtime, tautree::ZdcCtime,
// zdc information do not exist in MC
// tautree::ZdcAenergy, tautree::ZdcCenergy,
// tautree::ZdcAtime, tautree::ZdcCtime,
// tautree::Qtot,
tautree::TotalFT0AmplitudeA, tautree::TotalFT0AmplitudeC, tautree::TotalFV0AmplitudeA,
// tautree::TimeFT0A, tautree::TimeFT0C, tautree::TimeFV0A,
Expand Down Expand Up @@ -248,8 +249,9 @@ DECLARE_SOA_TABLE(TrueTauSixTracks, "AOD", "TRUETAUSIX",
// tautree::Trs, tautree::Trofs, tautree::Hmpr,
// tautree::Tfb, tautree::ItsRofb, tautree::Sbp, tautree::ZvtxFT0vsPv, tautree::VtxITSTPC,
//
tautree::ZdcAenergy, tautree::ZdcCenergy,
tautree::ZdcAtime, tautree::ZdcCtime,
// ZDC information do not exist in MC
// tautree::ZdcAenergy, tautree::ZdcCenergy,
// tautree::ZdcAtime, tautree::ZdcCtime,
// tautree::Qtot,
tautree::TotalFT0AmplitudeA, tautree::TotalFT0AmplitudeC, tautree::TotalFV0AmplitudeA,
// tautree::TimeFT0A, tautree::TimeFT0C, tautree::TimeFV0A,
Expand Down
100 changes: 50 additions & 50 deletions PWGUD/TableProducer/tauThreeProngEventTableProducer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,7 @@ struct TauThreeProngEventTableProducer {
// different events flags
int8_t bcSels[8] = {-99, -99, -99, -99, -99, -99, -99, -99};
uint8_t bcSelBits = 0;
const int nBitsMax = 8;
bcSels[0] = dgcand.trs();
bcSels[1] = dgcand.trofs();
bcSels[2] = dgcand.hmpr();
Expand All @@ -845,7 +846,7 @@ struct TauThreeProngEventTableProducer {

const int offset = 1;
bcSelBits = bcSels[0]; // initialization
for (int ibit = 1; ibit < 8; ibit++) {
for (int ibit = 1; ibit < nBitsMax; ibit++) {
bcSelBits = (bcSelBits << offset); // shift by 1 position towards left
bcSelBits += bcSels[ibit]; // add next bit to the pool
}
Expand Down Expand Up @@ -1257,7 +1258,7 @@ struct TauThreeProngEventTableProducer {
continue;
}

registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(3., 1.); // particles from tau in |eta|<0.9
registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(3., 1.); // charged particles from tau in |eta|<0.9

registrySkim.get<TH1>(HIST("skim/nChPartMC"))->Fill(nChargedDaughtersTau[0] + nChargedDaughtersTau[1]); // N charged particles from taus
// check number of charged particles in MC event
Expand All @@ -1267,18 +1268,12 @@ struct TauThreeProngEventTableProducer {
continue;
}

registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(4., 1.); // 1+3 (3+3) topology
if (nChargedDaughtersTau[0] + nChargedDaughtersTau[1] == fourTracks) { // 4
registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(5., 1.);
} else if (nChargedDaughtersTau[0] + nChargedDaughtersTau[1] == sixTracks) { // 6
registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(6., 1.);
}

// if (nChargedDaughtersTau[0] + nChargedDaughtersTau[1] == fourTracks) { // 4
// registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(7., 1.);
// } else if (nChargedDaughtersTau[0] + nChargedDaughtersTau[1] == sixTracks) { // 6
// registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(8., 1.);
// }
registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(4., 1.); // 1+3 (3+3) topology = 4 or 6 tracks
// if (nChargedDaughtersTau[0] + nChargedDaughtersTau[1] == fourTracks) { // 4
// registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(5., 1.);
// } else if (nChargedDaughtersTau[0] + nChargedDaughtersTau[1] == sixTracks) { // 6
// registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(6., 1.);
// }

if ((nChargedDaughtersTau[0] == oneProng) || // 1
(nChargedDaughtersTau[0] == threeProng && nChargedDaughtersTau[1] == threeProng)) // 3 and 3
Expand All @@ -1303,11 +1298,12 @@ struct TauThreeProngEventTableProducer {
double hadronicRate = -999.;
int8_t bcSels[8] = {-99, -99, -99, -99, -99, -99, -99, -99};
uint8_t bcSelBits = 0;
const int nBitsMax = 8;
// zdc information - there is no information in MC
float energyZNA = -999.;
float energyZNC = -999.;
float timeZNA = -999.;
float timeZNC = -999.;
// float energyZNA = -999.;
// float energyZNC = -999.;
// float timeZNA = -999.;
// float timeZNC = -999.;

float amplitudesFIT[3] = {-999., -999., -999.}; // FT0A, FT0C, FV0
// float timesFIT[3] = {-999., -999., -999.}; // FT0A, FT0C, FV0
Expand Down Expand Up @@ -1350,7 +1346,7 @@ struct TauThreeProngEventTableProducer {
float trueDaugY[6] = {-998., -998., -998., -998., -998., -998.};
float trueDaugZ[6] = {-998., -998., -998., -998., -998., -998.};
int trueDaugPdgCode[6] = {-999, -999, -999, -999, -999, -999};
// bool problem = false;

MyRecoProblem problem = NO_PROBLEM;
registrySkim.get<TH1>(HIST("skim/problemMC"))->Fill(NO_PROBLEM);

Expand All @@ -1360,14 +1356,19 @@ struct TauThreeProngEventTableProducer {
// 3 = pi+3pi
// 4 = 3pi+3pi

if (nElec == oneProng && nPi == threeProng) // 1 + 3
if (nElec == oneProng && nPi == threeProng) { // 1 + 3
trueChannel = 1;
else if (nMuon == oneProng && nPi == threeProng) // 1 + 3
registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(5., 1.);
} else if (nMuon == oneProng && nPi == threeProng) { // 1 + 3
trueChannel = 2;
else if (nPi == fourTracks) // 4
registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(6., 1.);
} else if (nPi == fourTracks) { // 4
trueChannel = 3;
else if (nPi == sixTracks) // 6
registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(7., 1.);
} else if (nPi == sixTracks) { // 6
trueChannel = 4;
registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(8., 1.);
}

// LOGF(info, "MC Coll global index %d", mccoll.globalIndex());
// LOGF(info, "2. <MC> UDMcCollision size %d, Collisions size %d, UDtracks %d, UDMcParticles %d", mcCollisions.size(), collisions.size(), tracks.size(), mcParticles.size());
Expand All @@ -1383,6 +1384,7 @@ struct TauThreeProngEventTableProducer {
if (collFromMcColls.size() > 0) { // get the truth and reco-level info
if (verbose)
LOGF(info, "--- MC Collision has reconstructed collision!");
registrySkim.get<TH1>(HIST("skim/efficiencyMC"))->Fill(9., 1.);
// trueHasRecoColl = true;
// check there is exactly one reco-level collision associated to generated collision
if (collFromMcColls.size() > 1) {
Expand Down Expand Up @@ -1446,7 +1448,7 @@ struct TauThreeProngEventTableProducer {

const int offset = 1;
bcSelBits = bcSels[0]; // initialization
for (int ibit = 1; ibit < 8; ibit++) {
for (int ibit = 1; ibit < nBitsMax; ibit++) {
bcSelBits = (bcSelBits << offset); // shift by 1 position towards left
bcSelBits += bcSels[ibit]; // add next bit to the pool
}
Expand Down Expand Up @@ -1624,8 +1626,8 @@ struct TauThreeProngEventTableProducer {
bcSelBits,
// bcSels[0], bcSels[1], bcSels[2], // to test it
// bcSels[3], bcSels[4], bcSels[5], bcSels[6], bcSels[7],
energyZNA, energyZNC,
timeZNA, timeZNC,
// energyZNA, energyZNC,
// timeZNA, timeZNC,
// qtot, <<-------- comment out
amplitudesFIT[0], amplitudesFIT[1], amplitudesFIT[2],
// timesFIT[0], timesFIT[1], timesFIT[2],
Expand Down Expand Up @@ -1656,8 +1658,8 @@ struct TauThreeProngEventTableProducer {
bcSelBits,
// bcSels[0], bcSels[1], bcSels[2], // to test it
// bcSels[3], bcSels[4], bcSels[5], bcSels[6], bcSels[7],
energyZNA, energyZNC,
timeZNA, timeZNC,
// energyZNA, energyZNC,
// timeZNA, timeZNC,
// qtot, <<-------- comment out
amplitudesFIT[0], amplitudesFIT[1], amplitudesFIT[2],
// timesFIT[0], timesFIT[1], timesFIT[2],
Expand Down Expand Up @@ -1839,7 +1841,7 @@ struct TauThreeProngEventTableProducer {
continue;
}

registrySkim.get<TH1>(HIST("gen/efficiencyMC"))->Fill(3., 1.); // particles from tau in |eta|<=0.9
registrySkim.get<TH1>(HIST("gen/efficiencyMC"))->Fill(3., 1.); // charged particles from tau in |eta|<=0.9

registrySkim.get<TH1>(HIST("gen/nChPartMC"))->Fill(nChargedDaughtersTau[0] + nChargedDaughtersTau[1]); // N charged particles from taus
// check number of charged particles in MC event
Expand All @@ -1850,11 +1852,6 @@ struct TauThreeProngEventTableProducer {
}

registrySkim.get<TH1>(HIST("gen/efficiencyMC"))->Fill(4., 1.); // 1+3 (3+3) topology = 4 or 6 tracks
// if (nChargedDaughtersTau[0] + nChargedDaughtersTau[1] == fourTracks) { // 4
// registrySkim.get<TH1>(HIST("gen/efficiencyMC"))->Fill(5., 1.);
// } else if (nChargedDaughtersTau[0] + nChargedDaughtersTau[1] == sixTracks) { // 6
// registrySkim.get<TH1>(HIST("gen/efficiencyMC"))->Fill(6., 1.);
// }

if ((nChargedDaughtersTau[0] == oneProng) || // 1
(nChargedDaughtersTau[0] == threeProng && nChargedDaughtersTau[1] == threeProng)) // 3 and 3
Expand Down Expand Up @@ -1890,22 +1887,6 @@ struct TauThreeProngEventTableProducer {
registrySkim.get<TH1>(HIST("gen/efficiencyMC"))->Fill(8., 1.);
}

bool trueHasRecoColl = false;
// find reconstructed collisions associated to the generated collision
auto const& collFromMcColls = collisions.sliceBy(colPerMcCollision, mccoll.globalIndex());
if (verbose)
LOGF(info, "-- coll from MC Coll %d", collFromMcColls.size());
// check the generated collision was reconstructed
if (collFromMcColls.size() > 0) { // get the truth and reco-level info
trueHasRecoColl = true;
registrySkim.get<TH1>(HIST("gen/efficiencyMC"))->Fill(9., 1.);
if (verbose)
LOGF(info, "--- MC Collision has reconstructed collision!");
} else { // get only the truth information.
if (verbose)
LOGF(info, "MC Collision has NO reconstructed collision!");
}

// get particles associated to generated collision
auto const& partsFromMcColl = mcParticles.sliceBy(partPerMcCollision, mccoll.globalIndex());
if (verbose)
Expand Down Expand Up @@ -1959,6 +1940,25 @@ struct TauThreeProngEventTableProducer {
// decide the channel and set the variable.
trueChannel = trueChannel + countPi0 * 10 + zerothTau * 100;

//
// check whwther event is reconstructed
//
bool trueHasRecoColl = false;
// find reconstructed collisions associated to the generated collision
auto const& collFromMcColls = collisions.sliceBy(colPerMcCollision, mccoll.globalIndex());
if (verbose)
LOGF(info, "-- coll from MC Coll %d", collFromMcColls.size());
// check the generated collision was reconstructed
if (collFromMcColls.size() > 0) { // get the truth and reco-level info
trueHasRecoColl = true;
registrySkim.get<TH1>(HIST("gen/efficiencyMC"))->Fill(9., 1.);
if (verbose)
LOGF(info, "--- MC Collision has reconstructed collision!");
} else { // get only the truth information.
if (verbose)
LOGF(info, "MC Collision has NO reconstructed collision!");
}

// LOGF(info, "Should be written!");

if (nChargedDaughtersTau[0] + nChargedDaughtersTau[1] == fourTracks) { // 4
Expand Down
Loading