Skip to content

[PWGLF] Add UseGoodItsLayersAll to event selection steps in data - #17646

Merged
abmodak merged 13 commits into
AliceO2Group:masterfrom
tutripat:master
Aug 30, 2026
Merged

[PWGLF] Add UseGoodItsLayersAll to event selection steps in data#17646
abmodak merged 13 commits into
AliceO2Group:masterfrom
tutripat:master

Conversation

@tutripat

@tutripat tutripat commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwglf label Aug 28, 2026
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add UseGoodItsLayersAll to event selection steps in data [PWGLF] Add UseGoodItsLayersAll to event selection steps in data Aug 28, 2026
tutripat and others added 2 commits August 28, 2026 09:06
@alibuild alibuild mentioned this pull request Aug 28, 2026
Merged
tutripat and others added 3 commits August 28, 2026 09:06
@tutripat
Merge pull request #18 from alibuild/alibot-cleanup-17646
cce97ca 
Please consider the following formatting changes to AliceO2Group#17646
@tutripat
Fixing formatting issues
d1498bd 
Removed unused constants and refactored event selection logic.
@alibuild
Please consider the following formatting changes
56c950a
@alibuild alibuild mentioned this pull request Aug 28, 2026
Merged
@tutripat
Merge pull request #19 from alibuild/alibot-cleanup-17646
cffeded 
Please consider the following formatting changes to AliceO2Group#17646
abmodak
abmodak previously approved these changes Aug 28, 2026
View reviewed changes
@abmodak
abmodak enabled auto-merge (squash) August 28, 2026 08:10
@alibuild

alibuild commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for cffeded at 2026-08-28 14:56:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 21 errors and 12 warnings.'
Found 21 errors and 12 warnings.
++ [[ 21 -gt 0 ]]
++ cat /sw/BUILD/f78cae51a2690d2222372c8167f525fd597252c6/O2Physics-code-check/errors.txt
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:72:10: error: variable 'ptAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:73:10: error: variable 'deltazAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:74:10: error: variable 'zAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:75:10: error: variable 'phiAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:76:10: error: variable 'etaAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:82:10: error: variable 'dcaXyAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:83:10: error: variable 'dcaZAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:84:10: error: variable 'dcaXAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:85:10: error: variable 'dcaYAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:93:10: error: variable 'centAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:96:10: error: variable 'vxAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:97:10: error: variable 'vyAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:99:10: error: variable 'recoTruthStatusAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:102:10: error: variable 'deltaVxAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:103:10: error: variable 'deltaVyAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:150:8: error: constructor does not initialize these fields: pdg, ccdbMgr [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:318:19: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:320:28: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:1618:14: error: constructor does not initialize these fields: bit [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2199:14: error: constructor does not initialize these fields: bit [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2506:14: error: constructor does not initialize these fields: bit [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 12 -gt 0 ]]
++ cat /sw/BUILD/f78cae51a2690d2222372c8167f525fd597252c6/O2Physics-code-check/warnings.txt
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:168:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:1537:103: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:1877:101: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2019:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2023:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2333:28: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2719:30: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2843:28: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2845:28: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2847:48: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:3243:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:3247:28: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 21 -gt 0 ]]
++ exit 1
--

Full log here.

@tutripat
Refactor AxisSpec declarations to const
fe4353d 
Changed AxisSpec declarations to const for better safety and clarity. Updated various variable initializations to use uniform initialization syntax.
auto-merge was automatically disabled August 28, 2026 14:13

Head branch was pushed to by a user without write access

@alibuild alibuild mentioned this pull request Aug 28, 2026
Merged
@tutripat
Merge pull request #20 from alibuild/alibot-cleanup-17646
dfa1bb3 
Please consider the following formatting changes to AliceO2Group#17646
@alibuild

alibuild commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for dfa1bb3 at 2026-08-28 17:14:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Aug 28, 2026
Merged
@tutripat
Merge pull request #21 from alibuild/alibot-cleanup-17646
0498e90 
Please consider the following formatting changes to AliceO2Group#17646
@abmodak
abmodak enabled auto-merge (squash) August 28, 2026 19:37
@alibuild

alibuild commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 0498e90 at 2026-08-30 03:02:

No log files found

Full log here.

@alibuild

alibuild commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0498e90 at 2026-08-30 04:45:

No log files found

Full log here.

@abmodak
abmodak merged commit 4d64e69 into AliceO2Group:master Aug 30, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abmodak abmodak abmodak approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tutripat @alibuild @abmodak