Repository navigation
[Aikido] Fix SQL injection bypass in asyncpg.executemany parameter extraction - #744
Closed
aikido-autofix[bot] wants to merge 1 commit into
Closed
aikido-autofix[bot] wants to merge 1 commit into
aikido-autofix[bot] wants to merge 1 commit into
Conversation
…y extracting command parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses a SQL injection vulnerability bypass in the asyncpg.executemany method where the security scanner was incorrectly extracting the query parameter instead of the command parameter, allowing malicious SQL to evade detection. A dedicated wrapper function
_executemanywas implemented to correctly identify and scan the command parameter for SQL injection attacks. The fix ensures proper vulnerability detection for batch query execution in asyncpg connections and includes comprehensive test coverage in aikido_zen/sinks/asyncpg.py and aikido_zen/sinks/tests/asyncpg_test.py.✅ 1 issue fixed by this PR
connection.executemany(command=statement, args=rows)._executerequestsquery, soget_argumentreturnsNone;context_contains_sql_injectionskips that value; and the wrapper proceeds to call the original method with the untouched arguments. No later check in this sink scanscommand. Consequently, SQL injection that this firewall is intended to detect and block can execute with the application's database role and evade the associated attack telemetry. The impact is conditional on an application endpoint constructing the command from attacker-influenced data, but that is the trust boundary the sink is intended to protect.