fix: raise descriptive ValueError on malformed turns instead of bare KeyError - #26
Merged
royalpinto007 merged 1 commit intoSep 17, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #14. One bad turn killed the whole suite load with a bare
ValueError(e.g.start_s: "soon") or bareKeyError(missing field). Nowfrom_dictraises a single descriptiveValueErrornaming the turn index and field, and validates speaker/text types.Changes
voiceeval/turns.py:from_dictvalidates the top-levelturnslist, then each turn field via a sharedturn_fieldhelper — missing keys, non-numericstart_s/end_s, and invalidspeaker/textall raise a descriptiveValueError.tests/test_from_dict_malformed.py: test-first (RED → GREEN), 10 cases covering missing/malformed fields and turn indexing.Checklist
Authored with AI assistance; verified locally.