fix: scope confirmation proximity for no_confirmation - #25
Merged
royalpinto007 merged 1 commit intoSep 16, 2026
Merged
royalpinto007 merged 1 commit into
royalpinto007 merged 1 commit into
Conversation
A confirmation anywhere in the call silenced no_confirmation for every later action. Scope it to a short window before the consequential action so a stale, unrelated confirmation no longer suppresses the finding. Closes AgentPostmortem#13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
no_confirmationsearched all prior agent turns for any confirmation. A stale, unrelated confirmation (e.g. a balance check at turn 1) silenced the finding for a $200 refund at turn 5 — no proximity scoping.Change
Scope the confirmation search to a short window (
_CONFIRM_WINDOW = 3turns) immediately before the consequential action. A confirmation that closely precedes the action still suppresses the finding (existinggood_callflow preserved: confirm → yes → action).Tests
Added a failing test first: an early different-topic confirmation (balance) followed by an unrelated later refund must still produce
no_confirmation. Full suite: 67 passed.Related
Closes #13