feat: detect confirmed wrong values in voice calls - #23
Merged
royalpinto007 merged 1 commit intoSep 13, 2026
Merged
royalpinto007 merged 1 commit into
royalpinto007 merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #20. A confirmation turn can echo a misheard amount and still satisfy the existing missing-confirmation check. Add a sibling
confirmed_wrong_valuecheck to flag contradictory ground-truth or bounded action evidence.Changes
Validation
Independent Astra High review and repairs; Python 3.12.13:
65 tests passed. Lint passed with Ruff 0.15.12. Changed-file formatting passed. Separate CLI assertions verified clean versus flagged fixture exit codes and output. Additional regression cases failed on the submitted version and passed after repair.
Ruff 0.16.7 reports the same five inherited diagnostics on base and final. Whole-tree formatting reports the same three unchanged files on both. Those baseline failures were preserved rather than suppressed or included in an unrelated cleanup. Python 3.11 and live STT/provider/call testing were not run locally.
Limitations
This is a bounded English heuristic, not a general spoken-number or semantic-field parser. Compound/signed/grouped forms are conservatively skipped where detected. Locale packs, word “zero”, numeric repetition/order and arbitrary confirmation language are not supported. A ground-truth contradiction flags the confirmation itself; it does not assert caller acceptance or an executed transaction. The README documents these boundaries.
Checklist
AI-assisted contribution, independently reviewed, repaired and tested by a separate Astra High subagent.