feat: add json-nonempty scorer - #54
Merged
royalpinto007 merged 1 commit intoSep 17, 2026
Merged
Conversation
Fails schema-valid-but-empty outputs ({}, {answer: ""}, all-null)
that still game structured-output evals. Wraps schema validation
with non-empty-leaf checks (minKeys, rejectBlankStrings, rejectNulls)
and registers the new json-nonempty type.
Closes AgentPostmortem#37
|
And it's in. Thanks @sharadvc. Good, focused change. Exactly the kind of thing Evalgate needs. If Evalgate is useful to you, a star goes a long way. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37
Models game structured-output evals with vacuous
{}/{"answer": ""}/ all-null payloads that still validate against the schema. The existingjson-schemascorer passes them.Change
src/scorers/json-nonempty.tsexporting aScorer(sibling tojson-schema.ts).json-nonemptytype inregistry.tsbuiltinScorers.minKeys(default 1),rejectBlankStrings(default true),rejectNulls(default true). Counts non-empty leaf values recursively; fails outputs with zero non-empty leaves.[Unreleased].Acceptance
ctx('{}')withminKeys: 1fails before the change.ctx('{"answer": "Paris"}')passes after.Tests cover the empty object, blank strings, all-null payloads,
minKeys, non-JSON input, and schema-rejection precedence.Full suite: 113/113 pass (
npm test);tsc --noEmitandeslintclean.This contribution was made with AI assistance (Claude).