fix: treat vendored and build dirs as a single trim candidate - #40
Merged
royalpinto007 merged 2 commits intoSep 18, 2026
Merged
Conversation
Don't descend into or read files in node_modules/vendor/dist/build directories. Record the directory once by name, sized from a cheap stat walk, so pattern output and byCategory totals are unchanged. Closes #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
The walker only skipped
.git, so it descended intonode_modules/,dist/,build/, etc. and fully read every file inside (up to 5 MB each) before classifying them as trimmable.Change
VENDOR_DIRS/BUILD_DIRSlists the classifier uses, before recursing.Acceptance criteria
scanRepoon a fixture containingnode_modules/does not read any file inside it (readFileSync/openSync/readSyncare never called for those files).byCategorytotals are unchanged on the sample fixture (verified byte-identical).Tests: 26/26 pass (
node --test). Version bumped 0.1.14 → 0.1.16 with a CHANGELOG entry.This contribution was made with AI assistance (Claude).