fix: CodexParser skips zero-length messages - #20
Merged
royalpinto007 merged 1 commit intoSep 16, 2026
Merged
Conversation
Empty-content message items were emitted as empty messages, polluting token totals — unlike the Claude and OpenAI parsers which already skip empties. Skip message items whose text is empty or whitespace-only. Closes AgentPostmortem#9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CodexParseremitted empty-contentmessageitems as empty messages — inconsistent with the Claude and OpenAI parsers, which already skip empties. Empty messages pollute token totals.Change
In
_emit_item, skipmessageitems whose text is empty or whitespace-only (mirrorsclaude_code.py'sif content.strip():convention). Turn numbers, tool calls, and reasoning are unaffected.Tests
Added a failing test first: a Codex session with empty
"content": ""and whitespace-only messages must skip them while keeping the real messages. Full suite: 62 passed.ruff checkclean.Related
Closes #9