Repository navigation
Refine Teams overviews, shared conversations and scoped deletion - #1750
Merged
Merged
Conversation
ZeroPoint95
marked this pull request as ready for review
October 5, 2026 12:52
ZeroPoint95
marked this pull request as draft
October 6, 2026 15:51
Collaborator
Author
|
converting to draft for now so we can implement a couple additional changes after team review |
ZeroPoint95
marked this pull request as ready for review
October 6, 2026 19:51
…leanup # Conflicts: # PERF.md # cmd/codeaf/chatv3_process.go
Collaborator
Author
|
ready to merge after two rounds of adversarial review |
ZeroPoint95
enabled auto-merge
October 7, 2026 16:06
ZeroPoint95
disabled auto-merge
October 7, 2026 16:06
ZeroPoint95
added a commit
that referenced
this pull request
Oct 14, 2026
- keys.md said ctrl+e closes, archives and reopens a conversation, that the strip's verb is `x close`, and that the card legend says `ctrl+e close`. Since #1750 ctrl+e on a conversation row opens the delete confirmation (legend `ctrl+e delete`), and enter reopens a dimmed row. - homeArchiveRow's comment says no key reaches it; tests still use it to make closed rows, so it stays. - A truth test fails if a section repeats the old claims; one probe, and the places heading for the box's rule gains the asker's words. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
ZeroPoint95
added a commit
that referenced
this pull request
Oct 14, 2026
…do (#1834) * fix: make home's ask-here hints and the /help digits name what the keys do - alt+enter on home belongs to the router (the composer layer); drop the unreachable alt+enter arm from home's ask-here case and keep ctrl+enter. - An errand row's foot says `enter or → answer this ask here` (and `enter answer this ask here · esc clear` over a draft); tab on the row is the next place. - The pane's `tab or esc back to the list` stays the last clause, so a 60-column frame keeps it; `/ commands` is not named while the pane has the keyboard. - /help numbers each place (`1 home · 2 AI teams · …`) instead of calling placeOrder the tab bar's order. - The manual pages say the same: ctrl+enter vs alt+enter, the row and pane feet, and which digit opens which place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: give the ask-here pane's box its own words, and raise its sheet on a phone - While an errand's pane holds the keyboard, the box under it says `type a follow-up` (or `type the change` after `o` on a card) instead of home's `type to search or start something new`. - On a phone-width window an errand's sheet now follows the pane's focus, so `ask here`, its chord and `→` on the row show the box the keys type into; before, only `enter` raised it and typed letters went nowhere visible. - The phone sheet's box draws the same sentence at rest. - Manual: the pane's box, ask here on a phone-width window, and the card's correction key (`o`, not `c`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: home's arrows never cross columns; say what → opens instead - keys.md, home.md, commands.md and places.md said ←/→ cross home's columns. Since 2026-09-17 every stop is in the field's one column and the rail is never walked: → opens the row's verbs, ← closes them, and on an ask-here row → hands the pane the keyboard. - The strip's words now match the code (x delete, p pause, s stop it), and the project row's `its chats` verb (removed in #1422) is no longer promised. - The phone inbox's folded project opens with → and folds with ←. - Comments in home.go, placekeys.go and verbstrip.go no longer cite the deleted homeView.crossColumns. - A truth test fails if any section repeats the crossing claims; three probes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: home's ctrl+e asks to delete, it does not close a tab - keys.md said ctrl+e closes, archives and reopens a conversation, that the strip's verb is `x close`, and that the card legend says `ctrl+e close`. Since #1750 ctrl+e on a conversation row opens the delete confirmation (legend `ctrl+e delete`), and enter reopens a dimmed row. - homeArchiveRow's comment says no key reaches it; tests still use it to make closed rows, so it stays. - A truth test fails if a section repeats the old claims; one probe, and the places heading for the box's rule gains the asker's words. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * changelog: entry for #1834 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * review: /help's digit row in commands.md, the o key, and leftovers - commands.md quoted /help's old `established shortcut order` row; it now quotes the numbered list, and a truth test refuses the old phrases. - asking-from-home: the way back is the last clause except while a change is being typed after `o`. - Comments call the correction key `o`, and the ctrl+x comment no longer says → crosses columns. - Remove the e2e rig's unused altEnter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: let the pane's card settle before the box-sentence test presses o #1833's settle guard drops a key that lands with the card, so the test pins the clock and moves it past questionSettle once the card has been drawn. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🆕 All teams and chat teams
What changed
Teams now provides a dedicated overview and management surface: nested team cards, faithful conversation previews, paged interactions, actionable questions, and an optional global manager. Recent interactions has persistent Prev and Next controls for paging in both directions through six-row pages. Active manager, member and Global manager cards show a working spinner that stops for questions and idle work, with static marks for ASCII and screen-reader views. Nested children stack in one column with parent labels, counts, and branch guides. Deeper or narrow hierarchies switch to expandable tree rows so descendants remain reachable without shrinking boxes indefinitely.
Chats meanwhile uses one synchronized team overlay selector and a fixed All button for the complete saved conversation library, including conversations without open tabs. A selected team appears as a chip: its name reopens the dropdown and its independent x restores ordinary Chats, synchronizing Teams to All teams. The dropdown lists actual teams only, without a None option.
Team creation uses a searchable Name/Project multi-select picker on Teams and card selection on Chats; both share the same catalog and creation flow. Membership removal preserves conversations and work.
Disbanding recursively ends coordination while retaining history; team deletion removes metadata but preserves conversations. Conversations can be deleted outright.
Conversation deletion stops work and removes its tasks, while task deletion removes only its containment subtree. Ordinary managers must be reassigned in Teams before conversation deletion, and one conversation cannot newly manage unrelated teams.
Deletion now enforces manager reassignment at the store boundary, validates task paths before mutation, waits for cancelled workers to finish, and keeps interrupted cleanup reachable from Home with startup recovery. Normal shutdown retains journal ownership through the cancelled run and releases it before run completion is published, allowing immediate restart. Replacing a parent manager explains the child-first reassignment order when that conversation also manages sibling subteams. Saved profile memories remain independent of transcript deletion.
Closing-report acceptance records its terminal interaction under the lifecycle lock and can retry a failed append without duplicating history. Hosted membership writes require a compatibility capability; current builds preserve unknown member fields and existing join boundaries. Team sheets and the Teams own-answer box retain typed stop-key letters, including with an empty underlying chat draft; cancelling restores the stop shortcut. Scrolled-off targets cannot intercept clicks on blank narrow-frame rows. Obsolete disband undo code was removed. Manuals, retrieval probes and the design record describe the final controls and refusals.
How it was checked
dev(362174a92), preserving contextual-memory changes alongside deletion.make pr-ready: light gate plus fresh complete suites for every changed package againstorigin/dev. No exemptions or test skips added.-race -count=1checks for worker completion, immediate restart, terminal-history retry and membership round-trips. Canonical temporary roots repair inherited macOS contextual-memory fixtures without changing their assertions.make buildproduces the canonicalbin/codeaf. Isolated terminal checks confirm modal typing, bidirectional six-row paging and the complete saved-conversation grid without the owner's profile or live model requests.xbefore the fix and passedBASE=326efd58c make pr-readyafter it, with fresh UI and manual suites.Checklist
1750-teams-ux-cleanup.md).For owner review; no merge is requested.