perf(file-browser): Migrate cachedDir to Map to prevent V8 hidden class degradation - #2829
Closed
AuDevTist1C wants to merge 1 commit into
Closed
perf(file-browser): Migrate cachedDir to Map to prevent V8 hidden class degradation#2829AuDevTist1C wants to merge 1 commit into
cachedDir to Map to prevent V8 hidden class degradation#2829AuDevTist1C wants to merge 1 commit into
Conversation
Contributor
Greptile SummaryReplaces the file browser’s object-based directory cache with an ES6
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "perf(file-browser): Convert directory ca..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Replace the plain object container used for cached directories with an ES6 `Map` to improve key lookup operations and key management semantics. Update cached directory data structure (`src/pages/fileBrowser/fileBrowser.js`): - Re-initialize `cachedDir` variable as a `Map` - Replace object property lookups with `Map.prototype.has()` and `Map.prototype.get()` - Update cache writes to use `Map.prototype.set()` - Update directory deletion calls to use `Map.prototype.delete()` (AI generated commit message)
AuDevTist1C
force-pushed
the
perf/fb-dir-cache-map
branch
from
August 29, 2026 10:15
928a14a to
cc77253
Compare
Member
|
remove the invented-looking benchmark table and GC/V8 claims.(the whole pr title + body is just slop there is nothing meaningfull) I'm closing this pr open new with real pr title , body instead of these slop otherwise I'll block |
github-project-automation
Bot
moved this from Backlog
to Done
in The Code Board - Acode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2831