examples(issue_resolver): rename shared helper to issue_resolver_common and remove GRANDFATHERED_EXAMPLES - #358
Open
mashood-memon wants to merge 2 commits into
Conversation
Contributor
|
Thanks @mashood-memon, this is the cleanest take on #233 so far. Before merge, please add a one-line note on Once that’s in and CI is green, good to merge, and I will change the assignee on the issue <3 |
mashood-memon
force-pushed
the
examples/issue-233-rename-issue-resolver-helper
branch
from
September 17, 2026 18:59
15bbf7a to
341d437
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233
What changed
examples/issue_resolver_github_context.py→examples/issue_resolver_common.pyto match the*_common.pyhelper module conventionexamples/claude_issue_resolver.py,examples/gemini_issue_resolver.py, andexamples/ollama_issue_resolver.pyGRANDFATHERED_EXAMPLESset and TODO comment fromtests/test_registry_docs.py— the existing*_common.pyfilter already excludes helperstests/test_examples_smoke.pyto reference the new filename### Changedentry toCHANGELOG.mdunder[Unreleased]Verification
pytest tests/test_registry_docs.py— 9 passedpytest tests/test_examples_smoke.py— same 5 pre-existing failures (missing optional packages:google,trafilatura,rembg,python-pptx,pillow), no new failures introducedNotes
examples/README.md,docs/usage/agent_loops.md, anddocs/skills/issue_resolver.mddo not referenceissue_resolver_github_context.py— no changes needed there