Skip to content

examples(issue_resolver): rename shared helper to issue_resolver_common and remove GRANDFATHERED_EXAMPLES - #358

Open
mashood-memon wants to merge 2 commits into
ARPAHLS:mainfrom
mashood-memon:examples/issue-233-rename-issue-resolver-helper
Open

mashood-memon wants to merge 2 commits into
ARPAHLS:mainfrom
mashood-memon:examples/issue-233-rename-issue-resolver-helper

Conversation

@mashood-memon

Copy link
Copy Markdown

Closes #233

What changed

  • Renamed examples/issue_resolver_github_context.pyexamples/issue_resolver_common.py to match the *_common.py helper module convention
  • Updated import in examples/claude_issue_resolver.py, examples/gemini_issue_resolver.py, and examples/ollama_issue_resolver.py
  • Removed GRANDFATHERED_EXAMPLES set and TODO comment from tests/test_registry_docs.py — the existing *_common.py filter already excludes helpers
  • Updated skip entry in tests/test_examples_smoke.py to reference the new filename
  • Added ### Changed entry to CHANGELOG.md under [Unreleased]

Verification

  • pytest tests/test_registry_docs.py — 9 passed
  • pytest tests/test_examples_smoke.py — same 5 pre-existing failures (missing optional packages: google, trafilatura, rembg, python-pptx, pillow), no new failures introduced

Notes

  • examples/README.md, docs/usage/agent_loops.md, and docs/skills/issue_resolver.md do not reference issue_resolver_github_context.py — no changes needed there

@rosspeili

Copy link
Copy Markdown
Contributor

Thanks @mashood-memon, this is the cleanest take on #233 so far.

Before merge, please add a one-line note on docs/skills/issue_resolver.md that the three *_issue_resolver.py scripts share examples/issue_resolver_common.py, plus a docs-only Skill history row (same bar as #274 review). No manifest bump needed.

Once that’s in and CI is green, good to merge, and I will change the assignee on the issue <3

@mashood-memon
mashood-memon force-pushed the examples/issue-233-rename-issue-resolver-helper branch from 15bbf7a to 341d437 Compare September 17, 2026 18:59

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Examples]: Rename issue_resolver_github_context.py to issue_resolver_common.py

2 participants