Skip to content

feat(standards): add set_procedure_role to Authority - #3885

Open
onurinanc wants to merge 6 commits into
nextfrom
feat-set-procedure-role
Open

onurinanc wants to merge 6 commits into
nextfrom
feat-set-procedure-role

Conversation

@onurinanc

Copy link
Copy Markdown
Collaborator

Summary

  • Add set_procedure_role, which rewrites one entry of the procedure-roles map on a running RbacControlled account, with 0 unmapping the procedure back to ADMIN.
  • Gate it on the emergency authority so it stays reachable while frozen and can carry its own role, and abort under OwnerControlled / AuthControlled, which have no roles map.
  • Refuse to reassign the procedure's own root, so role management cannot be locked behind a memberless role.

Closes #3864.

@partylikeits1983 partylikeits1983 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The authorization checks and frozen account behavior looks correct, I like the test coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add set_procedure_role to Authority

2 participants