Skip to content

Don't get notes in Tune init? #34

Description

@zmoon

This way, wouldn't have to reject tunes that the melody extraction doesn't currently support, enabling doing other things like working with the header data or viewing with abcjs, etc.. That is, we could wait to raise error until melody extraction is requested. Maybe use some cached properties. This should also make Tune init faster. Could also provide a simpler iterator that doesn't try to "play" the measures but just uses the note regex.

In #33 , a not-insignificant portion of The Session tunes (and 2 Norbeck tunes) are currently rejected (mostly because they have chords).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions