Bug: PcapSink::Trace() is not actually thread-safe, pcap output is corrupted under concurrent tracing

[nourfakhfakh93]

std::unique_lock<decltype(_lock)> lock;

This default-constructs a unique_lock that is not associated with _lock, it never actually locks the mutex. It looks like the intent was std::unique_lock<decltype(_lock)> lock(_lock);.

Waiting for your confirmation whether this is a bug, and waiting for the release containing the fix if so.

Thank you in advance.

[MariusBgm]

thanks for reporting.that is indeed a bug. that will bite you if you have transmits in parallel to receives.
Also, did you know that you can just easily link to code in the repo, without taking a screenshot. just click on the line number, and select "Copy permalink", and paste that line like this:

sil-kit/SilKit/source/tracing/PcapSink.cpp

Line 110 in 75fd429

std::unique_lock<decltype(_lock)> lock;