From 5fb6141dbd74483f1f535f7487c8ee4a326761ab Mon Sep 17 00:00:00 2001 From: ujiro99 Date: Tue, 22 Sep 2026 19:41:55 +0900 Subject: [PATCH] style: trim the uninstall URL comments Both notes explained at length why the extension can't send the event itself, which the linked issue already covers. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01HtiybZS7tYtWXK78B89PQJ --- packages/extension/src/background_script.ts | 3 +-- packages/extension/src/services/analytics.ts | 6 ++---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/extension/src/background_script.ts b/packages/extension/src/background_script.ts index 3d15e1f6..63a78e08 100644 --- a/packages/extension/src/background_script.ts +++ b/packages/extension/src/background_script.ts @@ -498,8 +498,7 @@ chrome.runtime.onInstalled.addListener(async (details) => { details.reason === chrome.runtime.OnInstalledReason.UPDATE ) { // Set uninstall survey URL with client_id for analysis. The version - // rides along so the Hub can put `app_version` on the GA4 `uninstall` - // event it sends on our behalf - by then this service worker is gone + // rides along for the `uninstall` event the Hub sends on our behalf // (selection-command-hub#275). // Wrapped in its own try/catch so a failure here (e.g. storage quota // error) does not skip the backup checks below. diff --git a/packages/extension/src/services/analytics.ts b/packages/extension/src/services/analytics.ts index 0cd390f6..5f638c67 100644 --- a/packages/extension/src/services/analytics.ts +++ b/packages/extension/src/services/analytics.ts @@ -55,10 +55,8 @@ export const ANALYTICS_EVENTS = { ONBOARDING_COMMAND_EXECUTE: "onboarding_command_execute", ONBOARDING_VALUE_REACHED: "onboarding_value_reached", ONBOARDING_COMPLETE: "onboarding_complete", - // No "uninstall" entry: the service worker is already torn down when the - // extension is removed, so that event is sent by the Hub instead, from the - // uninstall URL set in background_script.ts, using the client_id and - // version carried on it (selection-command-hub#275). + // No "uninstall": the service worker is gone by then, so the Hub sends it + // from the uninstall URL instead (selection-command-hub#275). } as const export type AnalyticsEventName =