style: アンインストールURL周りのコメントを削減 - #463
Merged
Merged
Conversation
Both notes explained at length why the extension can't send the event itself, which the linked issue already covers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HtiybZS7tYtWXK78B89PQJ
レビュー結果コメントの記述量削減のみの変更で、動作の変更はありません。内容を確認しましたが問題ありません。 確認したポイント
コード品質・スタイル
バグ・パフォーマンス・セキュリティ
テストカバレッジ
以上、特に修正が必要な指摘事項はありません。LGTM です。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
#462 のレビュー指摘(コメントが多すぎる)を受けたコメントのみの修正です。動作の変更はありません。
background_script.tsservices/analytics.tsどちらも「アンインストール時点でService Workerが破棄済みのため拡張からは送信できない」という同じ経緯を繰り返し説明していました。この経緯は ujiro99/selection-command-hub#275 に記載済みのため、コード側は参照のみに留めています。
Hub側の同種の削減(69行 → 26行)は ujiro99/selection-command-hub#276 に含めています。
Test plan
yarn workspace @selection-command/extension test:run src/background_script.test.ts(14件 pass)prettier --check差分なし🤖 Generated with Claude Code
https://claude.ai/code/session_01HtiybZS7tYtWXK78B89PQJ