Skip to content

make -j report two errors in debian 10, gcc8.3 with vcpkg folly #905

Open
Open
make -j report two errors in debian 10, gcc8.3 with vcpkg folly#905

Description

@abratio
abratio
opened on May 18, 2021

I installed folly by vcpkg in debian 10, compile this project with gcc8.3. Here is the error message when make -j:

/home/xqtu/repo/rsocket-cpp/rsocket/transports/tcp/TcpConnectionAcceptor.cpp:46:8: error: ‘void rsocket::TcpConnectionAcceptor::SocketCallback::acceptError(folly::exception_wrapper)’ marked ‘override’, but does not override
void acceptError(folly::exception_wrapper ex) noexcept override {
^~~~~~~~~~~
/home/xqtu/repo/rsocket-cpp/rsocket/transports/tcp/TcpConnectionAcceptor.cpp:46:8: warning: by ‘void rsocket::TcpConnectionAcceptor::SocketCallback::acceptError(folly::exception_wrapper)’ [-Woverloaded-virtual]
In file included from /usr/include/c++/8/memory:80,
from /home/xqtu/repo/vcpkg/installed/x64-linux/include/folly/IPAddress.h:21,
from /home/xqtu/repo/vcpkg/installed/x64-linux/include/folly/SocketAddress.h:26,
from /home/xqtu/repo/vcpkg/installed/x64-linux/include/folly/io/async/AsyncServerSocket.h:19,
from /home/xqtu/repo/rsocket-cpp/rsocket/transports/tcp/TcpConnectionAcceptor.h:17,
from /home/xqtu/repo/rsocket-cpp/rsocket/transports/tcp/TcpConnectionAcceptor.cpp:15:
/usr/include/c++/8/bits/unique_ptr.h: In instantiation of ‘typename std::_MakeUniq<_Tp>::__single_object std::make_unique(_Args&& ...) [with _Tp = rsocket::TcpConnectionAcceptor::SocketCallback; _Args = {std::function<void(std::unique_ptr<rsocket::DuplexConnection, std::default_deletersocket::DuplexConnection >, folly::EventBase&)>&}; typename std::_MakeUniq<_Tp>::__single_object = std::unique_ptrrsocket::TcpConnectionAcceptor::SocketCallback]’:
/home/xqtu/repo/rsocket-cpp/rsocket/transports/tcp/TcpConnectionAcceptor.cpp:83:68: required from here
/usr/include/c++/8/bits/unique_ptr.h:831:30: error: invalid new-expression of abstract class type ‘rsocket::TcpConnectionAcceptor::SocketCallback’
{ return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/xqtu/repo/rsocket-cpp/rsocket/transports/tcp/TcpConnectionAcceptor.cpp:26:30: note: because the following virtual functions are pure within ‘rsocket::TcpConnectionAcceptor::SocketCallback’:
class TcpConnectionAcceptor::SocketCallback
^~~~~~~~~~~~~~
In file included from /home/xqtu/repo/rsocket-cpp/rsocket/transports/tcp/TcpConnectionAcceptor.h:17,
from /home/xqtu/repo/rsocket-cpp/rsocket/transports/tcp/TcpConnectionAcceptor.cpp:15:
/home/xqtu/repo/vcpkg/installed/x64-linux/include/folly/io/async/AsyncServerSocket.h:174:18: note: ‘virtual void folly::AsyncServerSocket::AcceptCallback::acceptError(const std::exception&)’
virtual void acceptError(const std::exception& ex) noexcept = 0;
^~~~~~~~~~~
make[2]: *** [CMakeFiles/ReactiveSocket.dir/build.make:661: CMakeFiles/ReactiveSocket.dir/rsocket/transports/tcp/TcpConnectionAcceptor.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1714: CMakeFiles/ReactiveSocket.dir/all] Error 2
make: *** [Makefile:163: all] Error 2

Your Environment

  • RSocket version(s) used: d4a6228 - (HEAD -> master, origin/master, origin/HEAD) Updating submodules

  • Other relevant libraries versions (eg. netty, ...):

  • Platform (eg. JVM version (javar -version) or Node version (node --version)):

  • OS and version (eg uname -a):
    Linux debian 4.19.0-6-amd64 Set up contbuild. #1 SMP Debian 4.19.67-2+deb10u1 (2019-09-20) x86_64 GNU/Linux
    gcc (Debian 8.3.0-6) 8.3.0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions