Take into account wildignore setting

[cassepipe]

I went and tried to see if nvimtree was taking wildignore options into account and it does not.

It would make a lot of sense if it did.

What do you think ?

For reference :

	*'wildignore'* *'wig'*
'wildignore' 'wig'	string	(default "")
			global
	A list of file patterns.  A file that matches with one of these
	patterns is ignored when expanding |wildcards|, completing file or
	directory names, and influences the result of |expand()|, |glob()| and
	|globpath()| unless a flag is passed to disable this.
	The pattern is used like with |:autocmd|, see |autocmd-pattern|.
	Also see 'suffixes'.
	Example:  
		:set wildignore=*.o,*.obj
 	The use of |:set+=| and |:set-=| is preferred when adding or removing
	a pattern from the list.  This avoids problems when a future version
	uses another default.

[alex-courtis]

Interesting.

What would wildignore apply to?

[cassepipe]

@gegoune Yes H is forToggle Dotfiles I mention just above and U is for Toggle Hidden. You can see both with g? when focusing the explorer. If you happen to know the diefference, I am interested.

What do you think of this idea of taking into account whether that option is set ?

[alex-courtis]

We should keep it simple and keep all the filters orthogonal.

We could add new API api.tree.toggle_wildignore_filter and the functionality to filters.lua.

[alex-courtis]

Alternatively we could to just add nvim-tree.filters.custom_function and give full power to the user instead.

custom_function would take an (absolute) path - that's all the information we have.

[cassepipe]

Ok, so from what I understand from the docs page Toggle Hidden toggles displaying files based on a custom filter.

I still think it would be a pity a to require the user to write a custom filter function to take wildignore into account since the very existence of that option is to have vim ignore files, shouldn't be the default ?

[alex-courtis]

I still think it would be a pity a to require the user to write a custom filter function to take wildignore into account since the very existence of that option is to have vim ignore files, shouldn't be the default ?

If we were building the tree from scratch today, yes. Unfortunately that would break existing users, so we may only add opt-in functionality.