From 2ea0955b59409afb3610cd6a533f222409fc45df Mon Sep 17 00:00:00 2001
From: global-prog <raqeeb@uosamarra.edu.iq>
Date: Wed, 9 Sep 2026 03:33:57 +0300
Subject: [PATCH] feat: copy questions from another form

Rebuilding the same question set by hand for each new form is tedious, and the server
already knew how to clone a question together with its options - it simply refused to
do so across forms.

That restriction is lifted for forms the user is allowed to EDIT. Simply dropping the
same-form test would not have been safe: any question could then be read out of any
form by guessing ids, so the source form is permission-checked.

One bug had to be fixed for this to work at all: Question::read() carries the source
question's formId, so a clone taken from another form would have been created back in
that form rather than in the target one. The target id is now set explicitly.

A dialog lists the forms the user can edit, then the questions of the chosen one, with
select-all. Copies are made sequentially because each is appended at the end of the
form, and issuing them in parallel would give an unpredictable resulting order. A
partial failure reports that some questions were copied rather than implying none were.

No schema change, and no change to the API surface: the existing fromId parameter and
its documented behaviour are unchanged for same-form cloning.

Signed-off-by: global-prog <raqeeb@uosamarra.edu.iq>
---
 lib/Controller/ApiController.php         |  12 +-
 src/components/ImportQuestionsDialog.vue | 332 +++++++++++++++++++++++
 src/views/Create.vue                     |  41 +++
 3 files changed, 383 insertions(+), 2 deletions(-)
 create mode 100644 src/components/ImportQuestionsDialog.vue

diff --git a/lib/Controller/ApiController.php b/lib/Controller/ApiController.php
index ebc411fd1..47e7979df 100644
--- a/lib/Controller/ApiController.php
+++ b/lib/Controller/ApiController.php
@@ -570,9 +570,14 @@ public function newQuestion(int $formId, ?string $type = null, ?string $subtype
 
 			try {
 				$sourceQuestion = $this->questionMapper->findById($fromId);
-				// Only allow cloning questions that belong to the same form
+				// A question may be cloned from another form, but only from one the user is
+				// allowed to edit. Without that check any question could be read out of any
+				// form by guessing ids.
 				if ($sourceQuestion->getFormId() !== $formId) {
-					throw new OCSBadRequestException('Question doesn\'t belong to given form');
+					$this->formsService->getFormIfAllowed(
+						$sourceQuestion->getFormId(),
+						Constants::PERMISSION_EDIT,
+					);
 				}
 				$sourceOptions = $this->optionMapper->findByQuestion($fromId);
 			} catch (IMapperException) {
@@ -584,6 +589,9 @@ public function newQuestion(int $formId, ?string $type = null, ?string $subtype
 
 			$questionData = $sourceQuestion->read();
 			unset($questionData['id']);
+			// read() carries the source question's formId, so a clone taken from another
+			// form would otherwise be created back in that form rather than this one.
+			$questionData['formId'] = $formId;
 
 			if ($position !== null) {
 				$position = $this->shiftQuestionsForInsert($allQuestions, $position);
diff --git a/src/components/ImportQuestionsDialog.vue b/src/components/ImportQuestionsDialog.vue
new file mode 100644
index 000000000..c6201eb58
--- /dev/null
+++ b/src/components/ImportQuestionsDialog.vue
@@ -0,0 +1,332 @@
+<!--
+  - SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+  - SPDX-License-Identifier: AGPL-3.0-or-later
+-->
+
+<template>
+	<NcDialog
+		:open="open"
+		:name="t('forms', 'Import questions')"
+		size="normal"
+		@update:open="$emit('update:open', $event)">
+		<div class="import">
+			<NcLoadingIcon v-if="loadingForms" :size="32" />
+
+			<NcEmptyContent
+				v-else-if="otherForms.length === 0"
+				:name="t('forms', 'No other forms to import from')">
+				<template #description>
+					{{
+						t(
+							'forms',
+							'Questions can be imported from any form you are able to edit.',
+						)
+					}}
+				</template>
+			</NcEmptyContent>
+
+			<template v-else>
+				<label class="import__row">
+					<span>{{ t('forms', 'Copy from') }}</span>
+					<select
+						:value="selectedFormId ?? ''"
+						:aria-label="t('forms', 'Form to copy questions from')"
+						@change="onSelectForm">
+						<option disabled value="">
+							{{ t('forms', 'Choose a form') }}
+						</option>
+						<option
+							v-for="candidate in otherForms"
+							:key="candidate.id"
+							:value="candidate.id">
+							{{ candidate.title || t('forms', 'Untitled form') }}
+						</option>
+					</select>
+				</label>
+
+				<NcLoadingIcon v-if="loadingQuestions" :size="32" />
+
+				<template v-else-if="selectedFormId">
+					<p v-if="questions.length === 0" class="import__empty">
+						{{ t('forms', 'That form has no questions to copy.') }}
+					</p>
+					<template v-else>
+						<NcCheckboxRadioSwitch
+							:modelValue="allChosen"
+							@update:modelValue="onToggleAll">
+							{{ t('forms', 'Select all') }}
+						</NcCheckboxRadioSwitch>
+						<ul class="import__list">
+							<li v-for="question in questions" :key="question.id">
+								<NcCheckboxRadioSwitch
+									:modelValue="chosen.includes(question.id)"
+									@update:modelValue="
+										onToggle(question.id, $event)
+									">
+									{{
+										question.text
+										|| t('forms', 'Untitled question')
+									}}
+									<span class="import__type">
+										{{ typeLabel(question.type) }}
+									</span>
+								</NcCheckboxRadioSwitch>
+							</li>
+						</ul>
+					</template>
+				</template>
+			</template>
+		</div>
+
+		<template #actions>
+			<NcButton
+				:disabled="chosen.length === 0 || importing"
+				variant="primary"
+				@click="onImport">
+				<template v-if="importing" #icon>
+					<NcLoadingIcon :size="20" />
+				</template>
+				{{ t('forms', 'Copy') }}
+			</NcButton>
+		</template>
+	</NcDialog>
+</template>
+
+<script lang="ts">
+import type { PropType } from 'vue'
+import type { FormsForm, FormsQuestion } from '../types/Entities.d.ts'
+
+import axios from '@nextcloud/axios'
+import { showError } from '@nextcloud/dialogs'
+import { t } from '@nextcloud/l10n'
+import { generateOcsUrl } from '@nextcloud/router'
+import { computed, defineComponent, ref, watch } from 'vue'
+import NcButton from '@nextcloud/vue/components/NcButton'
+import NcCheckboxRadioSwitch from '@nextcloud/vue/components/NcCheckboxRadioSwitch'
+import NcDialog from '@nextcloud/vue/components/NcDialog'
+import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
+import NcLoadingIcon from '@nextcloud/vue/components/NcLoadingIcon'
+import answerTypes from '../models/AnswerTypes.ts'
+import logger from '../utils/Logger.ts'
+import OcsResponse2Data from '../utils/OcsResponse2Data.ts'
+
+export default defineComponent({
+	name: 'ImportQuestionsDialog',
+
+	components: {
+		NcButton,
+		NcCheckboxRadioSwitch,
+		NcDialog,
+		NcEmptyContent,
+		NcLoadingIcon,
+	},
+
+	props: {
+		open: {
+			type: Boolean,
+			default: false,
+		},
+
+		formId: {
+			type: Number as PropType<number>,
+			required: true,
+		},
+	},
+
+	emits: ['update:open', 'imported'],
+
+	setup(props, { emit }) {
+		const forms = ref<FormsForm[]>([])
+		const questions = ref<FormsQuestion[]>([])
+		const chosen = ref<number[]>([])
+		const selectedFormId = ref<number | null>(null)
+		const loadingForms = ref(false)
+		const loadingQuestions = ref(false)
+		const importing = ref(false)
+
+		const otherForms = computed(() =>
+			forms.value.filter((form) => form.id !== props.formId),
+		)
+
+		const allChosen = computed(
+			() =>
+				questions.value.length > 0
+				&& chosen.value.length === questions.value.length,
+		)
+
+		/**
+		 * @param type the answer type
+		 */
+		function typeLabel(type: string): string {
+			return answerTypes[type]?.label ?? type
+		}
+
+		/**
+		 *
+		 */
+		async function loadForms(): Promise<void> {
+			loadingForms.value = true
+			try {
+				const response = await axios.get(
+					generateOcsUrl('apps/forms/api/v3/forms'),
+				)
+				forms.value = OcsResponse2Data(response) ?? []
+			} catch (error) {
+				logger.error('Could not load forms to import from', { error })
+				showError(t('forms', 'Could not load your forms'))
+			} finally {
+				loadingForms.value = false
+			}
+		}
+
+		/**
+		 * @param event the select change
+		 */
+		async function onSelectForm(event: Event): Promise<void> {
+			selectedFormId.value = Number((event.target as HTMLSelectElement).value)
+			chosen.value = []
+			loadingQuestions.value = true
+			try {
+				const response = await axios.get(
+					generateOcsUrl('apps/forms/api/v3/forms/{id}', {
+						id: selectedFormId.value,
+					}),
+				)
+				questions.value = OcsResponse2Data(response)?.questions ?? []
+			} catch (error) {
+				logger.error('Could not load questions to import', { error })
+				showError(t('forms', 'Could not load the questions of that form'))
+				questions.value = []
+			} finally {
+				loadingQuestions.value = false
+			}
+		}
+
+		/**
+		 * @param questionId the question toggled
+		 * @param selected its new state
+		 */
+		function onToggle(questionId: number, selected: boolean): void {
+			chosen.value = selected
+				? [...chosen.value, questionId]
+				: chosen.value.filter((id) => id !== questionId)
+		}
+
+		/**
+		 * @param selected whether to select every question
+		 */
+		function onToggleAll(selected: boolean): void {
+			chosen.value = selected ? questions.value.map((q) => q.id) : []
+		}
+
+		/**
+		 *
+		 */
+		async function onImport(): Promise<void> {
+			importing.value = true
+			const created = []
+			try {
+				// Sequential rather than parallel: each copy is appended at the end of the
+				// form, so firing them at once would give an unpredictable order.
+				for (const question of questions.value) {
+					if (!chosen.value.includes(question.id)) {
+						continue
+					}
+					const response = await axios.post(
+						generateOcsUrl('apps/forms/api/v3/forms/{id}/questions', {
+							id: props.formId,
+						}),
+						{ fromId: question.id },
+					)
+					created.push(OcsResponse2Data(response))
+				}
+				emit('imported', created)
+				emit('update:open', false)
+			} catch (error) {
+				logger.error('Could not import questions', { error })
+				// Some may already have been copied, so do not imply that none were.
+				showError(
+					created.length
+						? t('forms', 'Only some questions could be copied')
+						: t('forms', 'Could not copy the questions'),
+				)
+				if (created.length) {
+					emit('imported', created)
+				}
+			} finally {
+				importing.value = false
+			}
+		}
+
+		watch(
+			() => props.open,
+			(isOpen) => {
+				if (isOpen) {
+					loadForms()
+				}
+			},
+			{ immediate: true },
+		)
+
+		return {
+			allChosen,
+			chosen,
+			importing,
+			loadingForms,
+			loadingQuestions,
+			onImport,
+			onSelectForm,
+			onToggle,
+			onToggleAll,
+			otherForms,
+			questions,
+			selectedFormId,
+			t,
+			typeLabel,
+		}
+	},
+})
+</script>
+
+<style lang="scss" scoped>
+.import {
+	display: flex;
+	flex-direction: column;
+	gap: 8px;
+	min-height: 120px;
+
+	&__row {
+		align-items: center;
+		display: flex;
+		flex-wrap: wrap;
+		gap: 8px;
+
+		select {
+			flex: 1 1 12ch;
+			min-height: var(--default-clickable-area);
+			min-width: 0;
+		}
+	}
+
+	&__list {
+		max-height: 320px;
+		overflow-y: auto;
+	}
+
+	&__type {
+		color: var(--color-text-maxcontrast);
+		margin-inline-start: 8px;
+	}
+
+	&__empty {
+		color: var(--color-text-maxcontrast);
+	}
+
+	@media (max-width: 512px) {
+		&__row {
+			align-items: stretch;
+			flex-direction: column;
+		}
+	}
+}
+</style>
diff --git a/src/views/Create.vue b/src/views/Create.vue
index 3bdd25f39..5c7d32335 100644
--- a/src/views/Create.vue
+++ b/src/views/Create.vue
@@ -207,7 +207,21 @@
 						:hasSubtypes="hasSubtypes"
 						primary
 						@addQuestion="addQuestion" />
+					<NcButton
+						:disabled="isLoadingQuestions"
+						variant="secondary"
+						@click="showImportDialog = true">
+						<template #icon>
+							<NcIconSvgWrapper :svg="IconImport" />
+						</template>
+						{{ t('forms', 'Import questions') }}
+					</NcButton>
 				</div>
+				<ImportQuestionsDialog
+					v-if="showImportDialog"
+					v-model:open="showImportDialog"
+					:formId="form.id"
+					@imported="onQuestionsImported" />
 			</section>
 		</template>
 	</NcAppContent>
@@ -217,6 +231,7 @@
 import type { ComponentPublicInstance, PropType } from 'vue'
 import type { FormsForm, FormsOption, FormsQuestion } from '../types/Entities.d.ts'
 
+import IconImport from '@material-symbols/svg-400/outlined/library_add.svg?raw'
 import IconLock from '@material-symbols/svg-400/outlined/lock.svg?raw'
 import axios from '@nextcloud/axios'
 import { showError } from '@nextcloud/dialogs'
@@ -230,11 +245,13 @@ import debounce from 'debounce'
 import { computed, defineComponent, nextTick, onMounted, ref, watch } from 'vue'
 import { VueDraggable as Draggable } from 'vue-draggable-plus'
 import NcAppContent from '@nextcloud/vue/components/NcAppContent'
+import NcButton from '@nextcloud/vue/components/NcButton'
 import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
 import NcIconSvgWrapper from '@nextcloud/vue/components/NcIconSvgWrapper'
 import NcLoadingIcon from '@nextcloud/vue/components/NcLoadingIcon'
 import NcNoteCard from '@nextcloud/vue/components/NcNoteCard'
 import AddQuestionMenu from '../components/AddQuestionMenu.vue'
+import ImportQuestionsDialog from '../components/ImportQuestionsDialog.vue'
 import Question from '../components/Questions/Question.vue'
 import QuestionLong from '../components/Questions/QuestionLong.vue'
 import QuestionMultiple from '../components/Questions/QuestionMultiple.vue'
@@ -260,9 +277,11 @@ export default defineComponent({
 	name: 'Create',
 	components: {
 		Draggable,
+		ImportQuestionsDialog,
 		NcIconSvgWrapper,
 		AddQuestionMenu,
 		NcAppContent,
+		NcButton,
 		NcEmptyContent,
 		NcLoadingIcon,
 		NcNoteCard,
@@ -631,6 +650,25 @@ export default defineComponent({
 		 * @param subtype the question subtype, see AnswerTypes.subtypes
 		 * @param position where the new question should be added
 		 */
+		const showImportDialog = ref(false)
+
+		/**
+		 * Append questions copied from another form.
+		 *
+		 * The server has already created them, so this only reflects them in the open
+		 * editor rather than refetching the whole form.
+		 *
+		 * @param created the questions the server returned
+		 */
+		const onQuestionsImported = (created: FormsQuestion[]): void => {
+			const questions = [
+				...props.form.questions,
+				...created.map((question) => ({ ...question, answers: [] })),
+			]
+			emit('update:form', { ...props.form, questions })
+			emitEvent('forms:last-updated:set', props.form.id)
+		}
+
 		const addQuestion = async (
 			type: string,
 			subtype: string | null = null,
@@ -828,6 +866,9 @@ export default defineComponent({
 			resizeTitle,
 			resizeDescription,
 			addQuestion,
+			showImportDialog,
+			onQuestionsImported,
+			IconImport,
 			deleteQuestion,
 			insertQuestion,
 			cloneQuestion,