From b6bfe9e6a75a6203801c7250e0261c8b0a1473e6 Mon Sep 17 00:00:00 2001 From: eivanov Date: Fri, 4 Sep 2026 14:51:21 +0400 Subject: [PATCH] fix: pass missing st argument to CIRCLE_send_no_work CIRCLE_send_work() called CIRCLE_send_no_work(dest) when a single work item exceeded the MPI_Send size limit, but the function's signature is CIRCLE_send_no_work(CIRCLE_state_st* st, int dest). Fix the call site to pass both st and dest, matching the other call sites of this function in the file. Also silence a -Wunused-parameter warning in CIRCLE_workreceipt_check() by explicitly marking the unused qp parameter, which is kept for API symmetry with the sibling function CIRCLE_workreq_check(). --- libcircle/token.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libcircle/token.c b/libcircle/token.c index 849e94b..90b5336 100644 --- a/libcircle/token.c +++ b/libcircle/token.c @@ -1545,7 +1545,7 @@ static int CIRCLE_send_work(CIRCLE_internal_queue_t* qp, CIRCLE_state_st* st, \ if(len > INT32_MAX) { LOG(CIRCLE_LOG_ERR, "Single work item too large to send (%zu bytes).", len); - CIRCLE_send_no_work(dest); + CIRCLE_send_no_work(st, dest); return -1; } @@ -1677,6 +1677,10 @@ static void CIRCLE_send_work_to_many(CIRCLE_internal_queue_t* qp, \ */ void CIRCLE_workreceipt_check(CIRCLE_internal_queue_t* qp, CIRCLE_state_st* st) { + /* qp is unused in this function, kept for API symmetry with + * CIRCLE_workreq_check() */ + (void) qp; + /* get MPI communicator */ MPI_Comm comm = st->comm;