Skip to content

The "fallback issue" action path to convert to PR is not very obvious/clear/friendly/encouraging #56571

Description

@dsyme

Look at this fallback issue created by gh-aw when a create-pull-request has tried to change a protected file: fabulous-dev/Fabulous#1181

The forward progress path for the user is in this warning

Image

Warning

Protected Files

This was originally intended as a pull request, but the patch modifies protected files. These files may affect project dependencies, CI/CD pipelines, or agent behaviour. Please review the changes carefully before creating the pull request.

Click here to create the pull request once you have reviewed the changes

However

  1. "Warning" really makes the user think that something bad is happening, and afraid, instead of realising that this is the forward progress path
  2. The forward progress path is at the bottom of the PR description, which may be a long way down and next to other warnings like firewall network access warnings

Instead, the top of the fallback issue should be a clear explanation of what has happened, telling the user everything is OK and they just neet confirm that they want to create a PR, use a couple of positive emoji then give the link, then explain the OG PR description is below, then give a "---" divider, then the OG PR description, then a "---", then any other warnings and footer.

Assess other issues we auto-create on similar paths and make similar improvements.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions