From 4759f81a6a57153618b35dc052d8fac3f41b76b7 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 18 Oct 2026 09:38:19 -0500 Subject: [PATCH 1/2] Inline the list icon in the empty occurrences list The partial called a bootstrap_svg helper that the gem doesn't define, so rendering it without occurrences raised a NoMethodError. Inline the Bootstrap Icons SVG instead, as the error actions already do. Session: claude://claude.ai/epitaxy/local_3aec44a6-88f2-4748-b579-16c5b9c08863 Co-Authored-By: Claude Opus 5.5 --- .../solid_errors/occurrences/_collection.html.erb | 4 +++- test/views/solid_errors/occurrences_collection_test.rb | 10 ++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 test/views/solid_errors/occurrences_collection_test.rb diff --git a/app/views/solid_errors/occurrences/_collection.html.erb b/app/views/solid_errors/occurrences/_collection.html.erb index a6b23c6..c755470 100644 --- a/app/views/solid_errors/occurrences/_collection.html.erb +++ b/app/views/solid_errors/occurrences/_collection.html.erb @@ -53,7 +53,9 @@ collection: occurrences, as: :occurrence %> <% else %>
- <%= bootstrap_svg "list-ul" %> + + + No occurrences yet…
<% end %> diff --git a/test/views/solid_errors/occurrences_collection_test.rb b/test/views/solid_errors/occurrences_collection_test.rb new file mode 100644 index 0000000..ccee9fe --- /dev/null +++ b/test/views/solid_errors/occurrences_collection_test.rb @@ -0,0 +1,10 @@ +require "test_helper" + +class SolidErrors::OccurrencesCollectionTest < ActionView::TestCase + test "an empty list of occurrences says so" do + render partial: "solid_errors/occurrences/collection", locals: {occurrences: SolidErrors::Occurrence.none, page: nil} + + assert_select "svg.bi-list-ul" + assert_select "span", text: "No occurrences yet…" + end +end From a0a7e1a9ce43a3fd1df079cd9e000867b8a2c8f9 Mon Sep 17 00:00:00 2001 From: Stephen Margheim Date: Mon, 19 Oct 2026 11:52:05 +0200 Subject: [PATCH 2/2] Say "No occurrences found" in the empty occurrences header Co-Authored-By: Claude Opus 5.5 (1M context) --- app/views/solid_errors/occurrences/_collection.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/solid_errors/occurrences/_collection.html.erb b/app/views/solid_errors/occurrences/_collection.html.erb index c755470..544eeaf 100644 --- a/app/views/solid_errors/occurrences/_collection.html.erb +++ b/app/views/solid_errors/occurrences/_collection.html.erb @@ -10,7 +10,7 @@

<% page_count = page.count %> <% if page_count.zero? %> - No posts found + No occurrences found <% elsif page.pages == 1 %> <%= page_count %> total <% else %>