From 15e926dec9488b04cf9b4a289e5a4c18e6cbb604 Mon Sep 17 00:00:00 2001 From: mchwang Date: Wed, 23 Sep 2026 16:56:46 -0700 Subject: [PATCH 1/2] Record selection accessibility review lesson --- AGENTS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/AGENTS.md b/AGENTS.md index 4aabe2d..16e6e74 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -22,6 +22,7 @@ For features with background jobs, polling, retries, cancellation, or shutdown: - Clear a submitted draft only if its current value and attachment still match what was submitted. Treat this as compare-and-swap behavior. - Preserve completed historical results, but visibly mark them stale when their snapshot, plan revision, assignment, or referenced code no longer matches. - When polling updates one part of the screen, update only that state. Preserve scroll position unless the user was already following the bottom. +- When a row or control's visual selection determines the current content or input, expose the same state with the appropriate accessibility attribute, such as `aria-current` or `aria-selected`, and test it across navigation. ## Required race regressions From f1adae441f8527fdb63a0ee7d21f96969278fe68 Mon Sep 17 00:00:00 2001 From: mchwang Date: Wed, 23 Sep 2026 16:59:49 -0700 Subject: [PATCH 2/2] Make review lesson capture a merge gate --- AGENTS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AGENTS.md b/AGENTS.md index 16e6e74..568d9bf 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -46,4 +46,4 @@ Every reproduced race requires a failing-before and passing-after regression. As - Before requesting automated review, report the current head, CI state, mergeability, unresolved threads, and deferred follow-up issues. - Reproduce summary-only review concerns or turn them into a concrete follow-up issue. Do not repeatedly patch vague wording without a failure case. - For each review round, record what changed, what was declined and why, and the regression evidence. Re-request review until a round returns no new findings. -- Before closing or merging a PR, extract the highest-value, broadly reusable lessons from its review and add concise rules to this file. Omit one-off implementation details and rules already covered here. +- Treat review-lesson extraction as a merge gate. Before invoking merge, classify every review finding in the PR body as: covered by an existing rule (cite it), captured by a new rule in this branch (cite it), or one-off (record why). Do not merge until this audit is complete and every required `AGENTS.md` update is included in the reviewed head. Omit rules that merely repeat existing guidance.