Skip to content

[utils] Widen isSafeDynamicKey parameter type from string to PropertyKey #10206

Description

@MajorLift

isSafeDynamicKey should be able to handle all PropertyKey types.

Activity

  1. gomesalexandre commented on Aug 31, 2026

    @gomesalexandre

    Went looking for isSafeDynamicKey to widen it and couldn't find it anywhere in this repo - turns out it actually lives in MetaMask/core (packages/controller-utils/src/util.ts), not here. Might be worth moving/re-filing this one over there so it doesn't sit unactionable in utils.

  2. changed the title [-]Widen `isSafeDynamicKey` parameter type from `string` to `PropertyKey`[/-] [+][utils] Widen `isSafeDynamicKey` parameter type from `string` to `PropertyKey`[/+] on Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions