Repository navigation
chore(ci): drop 32-bit Windows and move vendored libmpv back to zhongfly - #690
Merged
Merged
Conversation
The self-hosted mpv-winbuild fork only existed to provide i686 libmpv and long-lived pinnable tags. Dropping 32-bit Windows makes both reasons moot, so retire the fork and its maintenance load. - release.yml: remove the win-x86 (i686-pc-windows-msvc) matrix entry - release.yml/ci.yml: download libmpv/ffmpeg from zhongfly/mpv-winbuild again, resolving its latest release tag at runtime (it keeps only the last 30 days of builds, so a pinned tag would be pruned) - delete the now-obsolete bump-mpv-winbuild workflow and the MPV_WINBUILD_TAG pin/variable plumbing - enable the `avif-native` image feature unconditionally: the target-conditional exception only existed because i686 cannot drive dav1d-sys's vendored meson build - website: drop the Windows (x86) download entries - AGENTS.md: document the return to zhongfly and the dropped platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The self-hosted
Lolle2000la/mpv-winbuildfork existed for exactly two thingszhongfly/mpv-winbuilddoesn't provide:MPV_WINBUILD_TAGwould be pruned and break release builds.It was not created for ARM: zhongfly has shipped
aarch64since Sep 2024 (commitdabe61cf), and our aarch64 builds already used it when we first switched to zhongfly. So "zhongfly now supports ARM" doesn't change the calculus — dropping 32-bit Windows does.With
win-x86gone, reason (1) disappears, and reason (2) is handled by resolving zhongfly's latest tag at runtime. That lets us retire the fork and its maintenance load (LLVM/lld lockstep, curl patches, upstream merges).Changes
release.yml: drop thewin-x86(i686-pc-windows-msvc) matrix entry (Windows targets are nowwin-x64+win-arm64).release.yml/ci.yml: download libmpv/ffmpeg from zhongfly/mpv-winbuild again, resolving its latest release tag at runtime.bump-mpv-winbuild.ymland allMPV_WINBUILD_TAGpin plumbing. (A repo variable of that name, if it still exists, is now ignored.)avif-nativeimage feature unconditionally — the target-conditional exception only existed because i686 can't drive dav1d-sys's vendored meson build.website: drop the Windows (x86) download entries.AGENTS.md: update the docs (return to zhongfly, dropped platform, AVIF notes).Notes / trade-offs
Lolle2000la/mpv-winbuildbecomes unused and can be archived.Verification
cargo check -p media-sort-backend -p benchmarks✅ (confirms unconditionalavif-nativeresolves)cargo fmt --all -- --check✅