fix: resolve staticcheck issues across hawk codebase

- Replace nil contexts with context.TODO() (SA1012)
- Convert loop+append to single append calls (S1011)
- Replace strings.Title with cases.Title(language.English).String (SA1019)
- Use //lint:ignore SA1019 for deprecated parser.ParseDir/ast.Package
- Fix unnecessary leading zeros in numeric literals (ST1018)
- Convert raw string literals to interpreted strings (S1008)
- Replace inefficient append patterns (S1017)
- Remove unused functions and imports (U1000)
- Fix ineffective assignments (SA4006)
- Use labeled break for nested loop control (SA4011)
- Simplify if-else chains to switch statements (S1039)
- Remove empty critical sections (SA2001)
- Fix unnecessary nil checks (S1034)
- Fix missing return value handling (SA5011)

All tests pass with -race flag.

Author: Patel230

cmd/chat_commands_session.go

@@ -25,9 +25,7 @@ func (m *chatModel) saveSession() {
 	var msgs []session.Message
 	for _, rm := range raw {
 		sm := session.Message{Role: rm.Role, Content: rm.Content}
-		for _, tc := range rm.ToolUse {
-			sm.ToolUse = append(sm.ToolUse, tc)
-		}
+		sm.ToolUse = append(sm.ToolUse, rm.ToolUse...)
 		if len(rm.ToolResults) > 0 {
 			sm.ToolResults = make([]session.ToolResult, len(rm.ToolResults))
 			copy(sm.ToolResults, rm.ToolResults)
@@ -117,9 +115,7 @@ func (m *chatModel) handleSessionCommand(cmd string, parts []string, text string
 			var msgs []client.EyrieMessage
 			for _, sm := range s.Messages {
 				em := client.EyrieMessage{Role: sm.Role, Content: sm.Content}
-				for _, tc := range sm.ToolUse {
-					em.ToolUse = append(em.ToolUse, tc)
-				}
+				em.ToolUse = append(em.ToolUse, sm.ToolUse...)
 				if len(sm.ToolResults) > 0 {
 					em.ToolResults = make([]client.ToolResult, len(sm.ToolResults))
 					copy(em.ToolResults, sm.ToolResults)
@@ -165,9 +161,7 @@ func (m *chatModel) handleSessionCommand(cmd string, parts []string, text string
 		var msgs []client.EyrieMessage
 		for _, sm := range saved.Messages {
 			em := client.EyrieMessage{Role: sm.Role, Content: sm.Content}
-			for _, tc := range sm.ToolUse {
-				em.ToolUse = append(em.ToolUse, tc)
-			}
+			em.ToolUse = append(em.ToolUse, sm.ToolUse...)
 			if len(sm.ToolResults) > 0 {
 				em.ToolResults = make([]client.ToolResult, len(sm.ToolResults))
 				copy(em.ToolResults, sm.ToolResults)

cmd/chat_print.go

@@ -206,9 +206,7 @@ func saveEyrieSession(id string, sess *engine.Session) {
 	var msgs []session.Message
 	for _, rm := range raw {
 		sm := session.Message{Role: rm.Role, Content: rm.Content}
-		for _, tc := range rm.ToolUse {
-			sm.ToolUse = append(sm.ToolUse, tc)
-		}
+		sm.ToolUse = append(sm.ToolUse, rm.ToolUse...)
 		if len(rm.ToolResults) > 0 {
 			sm.ToolResults = make([]session.ToolResult, len(rm.ToolResults))
 			copy(sm.ToolResults, rm.ToolResults)
@@ -228,9 +226,7 @@ func toEyrieMessages(saved []session.Message) []client.EyrieMessage {
 	msgs := make([]client.EyrieMessage, 0, len(saved))
 	for _, sm := range saved {
 		em := client.EyrieMessage{Role: sm.Role, Content: sm.Content}
-		for _, tc := range sm.ToolUse {
-			em.ToolUse = append(em.ToolUse, tc)
-		}
+		em.ToolUse = append(em.ToolUse, sm.ToolUse...)
 		if len(sm.ToolResults) > 0 {
 			em.ToolResults = make([]client.ToolResult, len(sm.ToolResults))
 			copy(em.ToolResults, sm.ToolResults)

cmd/chat_welcome.go

@@ -299,8 +299,8 @@ func envSummaryWithSelection(provider, model string, includeSelection bool) stri
 
 func configCommandSummary(settings hawkconfig.Settings) string {
 	_ = settings
-	provider := displayConfigValue(hawkconfig.ActiveProvider(nil))
-	model := displayConfigValue(hawkconfig.ActiveModel(nil))
+	provider := displayConfigValue(hawkconfig.ActiveProvider(context.TODO()))
+	model := displayConfigValue(hawkconfig.ActiveModel(context.TODO()))
 	return fmt.Sprintf(`Setup (eyrie)
 
   /config  → paste API key (OS keychain) + pick model

cmd/contextual_help.go

@@ -624,11 +624,7 @@ func fuzzyMatch(query, target string) bool {
 			break
 		}
 	}
-	if suffixLen >= 3 {
-		return true
-	}
-
-	return false
+	return suffixLen >= 3
 }
 
 // SuggestHelp returns relevant help entries based on the current context.

cmd/dx.go

@@ -1,6 +1,7 @@
 package cmd
 
 import (
+	"context"
 	"encoding/json"
 	"fmt"
 	"os"
@@ -66,10 +67,10 @@ func doctorOutput(settings hawkconfig.Settings) string {
 	}
 	b.WriteString("\nProvider:\n")
 	b.WriteString(fmt.Sprintf("  Provider:    %s\n", effectiveProvider))
-	b.WriteString(fmt.Sprintf("  API key:     %s\n", maskedKeyStatus(hawkconfig.ActiveProvider(nil))))
+	b.WriteString(fmt.Sprintf("  API key:     %s\n", maskedKeyStatus(hawkconfig.ActiveProvider(context.TODO()))))
 
 	// Model configured (eyrie provider.json)
-	effectiveModel := strings.TrimSpace(hawkconfig.ActiveModel(nil))
+	effectiveModel := strings.TrimSpace(hawkconfig.ActiveModel(context.TODO()))
 	if effectiveModel == "" {
 		effectiveModel = "(not configured)"
 	}

cmd/markdown.go

@@ -775,12 +775,8 @@ func (r *MarkdownRenderer) renderTableFromLines(tableLines []string, width int)
 func parseTableRow(line string) []string {
 	// Remove leading/trailing |
 	line = strings.TrimSpace(line)
-	if strings.HasPrefix(line, "|") {
-		line = line[1:]
-	}
-	if strings.HasSuffix(line, "|") {
-		line = line[:len(line)-1]
-	}
+	line = strings.TrimPrefix(line, "|")
+	line = strings.TrimSuffix(line, "|")
 	parts := strings.Split(line, "|")
 	cells := make([]string, len(parts))
 	for i, p := range parts {
@@ -1078,11 +1074,7 @@ func hasIncompleteElement(s string) bool {
 			fenceCount++
 		}
 	}
-	if fenceCount%2 != 0 {
-		return true
-	}
-
-	return false
+	return fenceCount%2 != 0
 }
 
 // findSafeRenderPoint finds the longest prefix that can be safely rendered.

cmd/spinner_wave_test.go

@@ -1,7 +1,6 @@
 package cmd
 
 import (
-	"fmt"
 	"strings"
 	"testing"
 )
@@ -56,8 +55,3 @@ func TestSpinnerWave_GlyphUsesWaveColor(t *testing.T) {
 		t.Fatal("expected wave color on spinner glyph")
 	}
 }
-
-func fmtSpinnerWaveNeedle(index int) string {
-	c := spinnerWaveColors[index%spinnerWaveLen]
-	return fmt.Sprintf("38;2;%d;%d;%d", c[0], c[1], c[2])
-}

internal/bridge/sessioncapture/bridge_test.go

@@ -1,6 +1,9 @@
 package sessioncapture
 
-import "testing"
+import (
+	"context"
+	"testing"
+)
 
 func TestNewBridge_NoTrace(t *testing.T) {
 	// Save and clear PATH so trace won't be found
@@ -13,15 +16,15 @@ func TestNewBridge_NoTrace(t *testing.T) {
 
 func TestBridge_EnableWithoutCLI(t *testing.T) {
 	b := &Bridge{ready: false}
-	err := b.Enable(nil, "/tmp")
+	err := b.Enable(context.TODO(), "/tmp")
 	if err == nil {
 		t.Error("expected error when trace CLI not found")
 	}
 }
 
 func TestBridge_StatusWithoutCLI(t *testing.T) {
 	b := &Bridge{ready: false}
-	s, err := b.GetStatus(nil, "/tmp")
+	s, err := b.GetStatus(context.TODO(), "/tmp")
 	if err == nil {
 		t.Error("expected error when trace CLI not found")
 	}

internal/codegraph/codegraph_cgo.go

@@ -290,7 +290,7 @@ func (cg *CodeGraph) IndexFile(filePath string) error {
 		return err
 	}
 
-	tree, err := cg.parser.ParseCtx(nil, nil, source)
+	tree, err := cg.parser.ParseCtx(context.TODO(), nil, source)
 	if err != nil {
 		return err
 	}

internal/config/config_test.go

@@ -136,7 +136,7 @@ func TestLoadSettingsProjectMergeIncludesArchiveFields(t *testing.T) {
 	defer os.Chdir(orig)
 
 	settings := LoadSettings()
-	if got := ActiveModel(nil); got != "project" {
+	if got := ActiveModel(context.TODO()); got != "project" {
 		t.Fatalf("expected project model in eyrie, got %q (settings.model=%q)", got, settings.Model)
 	}
 	if settings.Model != "" {
@@ -170,7 +170,7 @@ func TestSetGlobalSettingAndSettingValue(t *testing.T) {
 	}
 
 	settings := LoadGlobalSettings()
-	if got := ActiveModel(nil); got != "test-model" {
+	if got := ActiveModel(context.TODO()); got != "test-model" {
 		t.Fatalf("unexpected active model: %q (settings.model=%q)", got, settings.Model)
 	}
 	if settings.Model != "" {