fix(examples): standardize wallet ID env var across Go Account scripts - #9732
Open
alia-bitgo wants to merge 1 commit into
Open
alia-bitgo wants to merge 1 commit into
alia-bitgo wants to merge 1 commit into
Conversation
Renames the local accountId variable to walletId in scripts that used it, matching the naming already used elsewhere, and fixes create-go-account-address.ts to read OFC_WALLET_ID instead of a hardcoded placeholder. TICKET: CAAS-2606
Contributor
mukeshsp
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accountIdvariable towalletIdin Go Account example scripts, matching the naming already used by the other scripts in the directorycreate-go-account-address.tsto readOFC_WALLET_IDinstead of a hardcoded placeholder, and adds the missing required-env-vars doc blockTest plan
tsc --noEmiton changed files (no new errors)accountIdoccurrences are API response/request interface fields, not local varsTICKET: CAAS-2606