From 9129d31df58a04324c7f4ec1525c5746ab3453d4 Mon Sep 17 00:00:00 2001 From: Ben Date: Sat, 5 Sep 2026 18:10:45 -0600 Subject: [PATCH] docs: separate review completeness from findings --- .github/skills/code-review/SKILL.md | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/.github/skills/code-review/SKILL.md b/.github/skills/code-review/SKILL.md index fb6446857..403efbb0f 100644 --- a/.github/skills/code-review/SKILL.md +++ b/.github/skills/code-review/SKILL.md @@ -246,11 +246,25 @@ Coverage: ``` -When required coverage and validation are complete with no findings, the findings -section is exactly `No findings.` Otherwise use `Review incomplete.` with specific -limitations, while still reporting verified findings. An explicitly scoped -static-only review can be complete within that scope but does not pass a gate -requiring builds. Do not add praise, scores, generic advice, or merge approval. +Determine review completeness independently from findings and publishing readiness: + +- Complete review with findings: when required coverage and validation evidence + are complete, report the verified findings in priority order and keep coverage + marked complete. Do not label the review incomplete or invent limitations merely + because defects were found. +- Complete review without findings: when required coverage and validation evidence + are complete and no findings remain, the findings section is exactly + `No findings.` +- Incomplete review, with or without findings: only when required coverage or + validation evidence is missing, unresolved, or stale, use `Review incomplete.` + with the actual limitations. Still report all verified findings; do not present + an incomplete review as a clean verdict. + +A completed, investigated check that demonstrates a defect is validation evidence, +not by itself a coverage gap; unresolved failures still block publishing. An +explicitly scoped static-only review can be complete within that scope but does +not pass a gate requiring builds. Do not add praise, scores, generic advice, or +merge approval. For a pre-publish gate, the implementation coordinator, not the reviewer, fixes accepted findings, reruns required checks, and obtains a fresh independent review