From 9a11adf0c28fa0d8a19b7307c00a970c2b882a23 Mon Sep 17 00:00:00 2001
From: Philippe Matray <phmatray@gmail.com>
Date: Thu, 3 Sep 2026 13:54:08 +0200
Subject: [PATCH] Build: publish symbols and Source Link with the packages
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The published packages carry no debug information at all. Checked against nuget.org:
Atypical.VirtualFileSystem 0.3.0 has no embedded PDB in any of its three target frameworks,
and no symbol package was ever pushed alongside it. A consumer stepping into this library
gets decompiled IL and no way back to the source.

Adds DotNet.ReproducibleBuilds to the two packable projects, which turns on Source Link,
deterministic builds, and DebugType=embedded — the portable PDB then travels inside the
assembly, so symbols work with no symbol-server configuration on the consumer's side.

Deliberately NOT paired with IncludeSymbols/SymbolPackageFormat=snupkg: with embedded PDBs no
separate .pdb is ever produced, so a snupkg would be packed empty, and nuget.org rejects those
with "The package does not contain any symbol (.pdb) files". That trap is what this change
avoids repeating here.

Verified: after the change both packages carry an embedded PDB (MPDB blob present in
Atypical.VirtualFileSystem.Core.dll and Atypical.VirtualFileSystem.GitHub.dll).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D7hy3BpcmrBsEfqE9uGrNp
---
 Directory.Build.props                                | 12 ++++++++++++
 .../Atypical.VirtualFileSystem.Core.csproj           |  4 ++++
 .../Atypical.VirtualFileSystem.GitHub.csproj         |  8 ++++++++
 3 files changed, 24 insertions(+)

diff --git a/Directory.Build.props b/Directory.Build.props
index 286b714..1d50859 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -7,6 +7,18 @@
     <Company>Atypical Consulting SRL</Company>
   </PropertyGroup>
 
+  <!-- Source Link -->
+  <!-- Consumed alongside DotNet.ReproducibleBuilds in the packable projects, which also turns on
+       deterministic builds and DebugType=embedded: the portable PDB then travels INSIDE the
+       assembly, so consumers can step into this code with no symbol-server configuration.
+       Deliberately NOT paired with IncludeSymbols/SymbolPackageFormat=snupkg — with embedded PDBs
+       no separate .pdb exists, so the snupkg would be packed empty and nuget.org rejects those
+       outright ("The package does not contain any symbol (.pdb) files"). -->
+  <PropertyGroup>
+    <PublishRepositoryUrl>true</PublishRepositoryUrl>
+    <EmbedUntrackedSources>true</EmbedUntrackedSources>
+  </PropertyGroup>
+
   <!-- Versioning -->
   <!-- https://saebamini.com/how-to-version-your-net-nuget-packages-libraries-and-assemblies-azure-yaml-pipelines-example-using-net-core-cli/ -->
   <PropertyGroup>
diff --git a/src/Atypical.VirtualFileSystem.Core/Atypical.VirtualFileSystem.Core.csproj b/src/Atypical.VirtualFileSystem.Core/Atypical.VirtualFileSystem.Core.csproj
index d515be0..f7e66eb 100644
--- a/src/Atypical.VirtualFileSystem.Core/Atypical.VirtualFileSystem.Core.csproj
+++ b/src/Atypical.VirtualFileSystem.Core/Atypical.VirtualFileSystem.Core.csproj
@@ -17,6 +17,10 @@
     
     <!-- Development dependencies -->
     <ItemGroup>
+      <PackageReference Include="DotNet.ReproducibleBuilds" Version="2.0.5">
+        <PrivateAssets>all</PrivateAssets>
+        <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      </PackageReference>
       <PackageReference Include="DefaultDocumentation" Version="1.2.5">
         <PrivateAssets>all</PrivateAssets>
         <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
diff --git a/src/Atypical.VirtualFileSystem.GitHub/Atypical.VirtualFileSystem.GitHub.csproj b/src/Atypical.VirtualFileSystem.GitHub/Atypical.VirtualFileSystem.GitHub.csproj
index 863158f..0938469 100644
--- a/src/Atypical.VirtualFileSystem.GitHub/Atypical.VirtualFileSystem.GitHub.csproj
+++ b/src/Atypical.VirtualFileSystem.GitHub/Atypical.VirtualFileSystem.GitHub.csproj
@@ -11,6 +11,14 @@
         <None Include="../../LICENSE" Pack="true" PackagePath="" />
     </ItemGroup>
 
+    <!-- Development dependencies -->
+    <ItemGroup>
+        <PackageReference Include="DotNet.ReproducibleBuilds" Version="2.0.5">
+            <PrivateAssets>all</PrivateAssets>
+            <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
+    </ItemGroup>
+
     <!-- Dependencies -->
     <ItemGroup>
         <PackageReference Include="Octokit" Version="14.0.0" />