Repository navigation
Conversation
❌ Test failure@HalfSweet: this pull request adds the AppImage from your GitHub repository to the AppImage catalog; the test reports the following. Could you have a look? HSync Tested:
Compatibility: not self-contained: uses the C library of the system; references glibc 2.35
First error in the log: What next: once the AppImage is fixed (e.g. in a new release), comment |
|
I reproduced this as a screenshot geometry issue using the original contents extracted from the v0.2.0 AppImage under Ubuntu 22.04 (amd64 via Colima/Rosetta), with networking disabled. The Xvfb screen is 800x600, while HSync opens a centered 1440x900 window. The run logs show:
Moving and resizing the same running window onto the screen reveals the controls. With IceWM started first and enough screen space, the entire startup interface renders; a Demo capture also completes offline with 131072 samples. Could the window-fitting code handle X11's |
|
@HalfSweet, thank you for the thorough reproduction; your diagnosis is exactly right, and sorry that it took a bug on our side to keep HSync out of the catalog. I checked the two patterns against the window-tree line you quoted. The final The 800x600 screen is a separate limitation: HSync's minimum height of 640 is more than the screen allows, so after the move the bottom of the window will still be cut off. A taller Xvfb screen is a wider change (the screenshot checks were calibrated on 800x600 captures) that the maintainers will decide on separately. Once #10302 is merged, this pull request will be re-tested so that the result reflects the fix. Generated by Claude Code |
…nore IceWM's own windows (#10302) A window larger than the 800x600 screen and centered on it has negative absolute coordinates, which xwininfo writes as +-320+-150; the patterns in fit_main_window() and take-screenshot.sh did not match them, so the largest matching window was IceWM's taskbar and the application stayed off screen (#10156, found by HalfSweet). The window manager's own windows are left out of the choice as well. Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
|
/retest |
❌ Test failureHSync Tested:
Compatibility: not self-contained: uses the C library of the system; references glibc 2.35
First error in the log: What next: once the AppImage is fixed (e.g. in a new release), comment |
|
Not sure whether my fix using Claude is correct. What is the application supposed to show on a 800x600 screen? |
|
@probonopd Your fix works in my local reproduction. This is the expected startup screen at 800×600, using The visible controls should include the Demo device selector, sampling settings, Trigger, Capture, search bar, and Add decoder. The central waveform area is intentionally empty until the user clicks Capture. The built-in Demo device works without hardware or networking; no application arguments are needed. The IceWM taskbar at the bottom belongs to the test desktop. I tested the original contents extracted from the v0.2.0 amd64 AppImage on Ubuntu 22.04 via Colima/Rosetta, with networking disabled and the same two WebKit rendering environment variables as the worker. The fixed fitter selects HSync and moves it to The latest failed run 38950528658 still used the old fitting code:
That run therefore does not validate #10302. Could you run a fresh test whose checkout includes |
|
/retest |
✅ Test passedPlease check that the screenshot shows the application's main window. HSync Tested:
Compatibility: not self-contained: uses the C library of the system; references glibc 2.35 Warnings:
|




Repository: https://github.com/HalfSweet/HSync
HSync_0.2.0_amd64.AppImageFound by
.github/workflows/discover-apps.yml, which looks for GitHubrepositories that publish AppImages but are not in the catalog yet. This
entry was not tested by a human; please review it before merging.